fix bug on cache delete #703

lunny · 2017-09-02T14:13:09Z

lunny commented

2017-09-02 14:13:09 +00:00

will fix #702

ipiao commented

2017-09-07 00:03:18 +00:00

(Migrated from github.com)

不知道ci怎么用，但是测试用例里会有assertEqualvalues的类型不匹配错误 @lunny

codecov-io commented

2017-09-09 02:59:48 +00:00

(Migrated from github.com)

Codecov Report

Merging #703 into master will increase coverage by 2.68%.
The diff coverage is 83.01%.

@@            Coverage Diff             @@
##           master     #703      +/-   ##
==========================================
+ Coverage   49.13%   51.82%   +2.68%     
==========================================
  Files          35       35              
  Lines        8226     8218       -8     
==========================================
+ Hits         4042     4259     +217     
+ Misses       3708     3473     -235     
- Partials      476      486      +10

Impacted Files	Coverage Δ
statement.go	`63.14% <100%> (+0.38%)`	⬆️
session_get.go	`71.79% <100%> (+31.41%)`	⬆️
session_find.go	`62.95% <100%> (+7.95%)`	⬆️
session_delete.go	`58.42% <100%> (+20%)`	⬆️
session_update.go	`51.13% <66.66%> (+2.1%)`	⬆️
session_insert.go	`57.07% <71.42%> (+2.55%)`	⬆️
cache_lru.go	`59.88% <83.33%> (+21.71%)`	⬆️
xorm.go	`64.78% <0%> (-2.82%)`	⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 763e1b2...97fc1d9. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/703?src=pr&el=h1) Report > Merging [#703](https://codecov.io/gh/go-xorm/xorm/pull/703?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/763e1b21e6c593711d59ecb8e1ca018178e6c7bd?src=pr&el=desc) will **increase** coverage by `2.68%`. > The diff coverage is `83.01%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/703/graphs/tree.svg?width=650&src=pr&token=yB5nO1krEe&height=150)](https://codecov.io/gh/go-xorm/xorm/pull/703?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #703 +/- ## ========================================== + Coverage 49.13% 51.82% +2.68% ========================================== Files 35 35 Lines 8226 8218 -8 ========================================== + Hits 4042 4259 +217 + Misses 3708 3473 -235 - Partials 476 486 +10 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/703?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [statement.go](https://codecov.io/gh/go-xorm/xorm/pull/703?src=pr&el=tree#diff-c3RhdGVtZW50Lmdv) | `63.14% <100%> (+0.38%)` | :arrow_up: | | [session\_get.go](https://codecov.io/gh/go-xorm/xorm/pull/703?src=pr&el=tree#diff-c2Vzc2lvbl9nZXQuZ28=) | `71.79% <100%> (+31.41%)` | :arrow_up: | | [session\_find.go](https://codecov.io/gh/go-xorm/xorm/pull/703?src=pr&el=tree#diff-c2Vzc2lvbl9maW5kLmdv) | `62.95% <100%> (+7.95%)` | :arrow_up: | | [session\_delete.go](https://codecov.io/gh/go-xorm/xorm/pull/703?src=pr&el=tree#diff-c2Vzc2lvbl9kZWxldGUuZ28=) | `58.42% <100%> (+20%)` | :arrow_up: | | [session\_update.go](https://codecov.io/gh/go-xorm/xorm/pull/703?src=pr&el=tree#diff-c2Vzc2lvbl91cGRhdGUuZ28=) | `51.13% <66.66%> (+2.1%)` | :arrow_up: | | [session\_insert.go](https://codecov.io/gh/go-xorm/xorm/pull/703?src=pr&el=tree#diff-c2Vzc2lvbl9pbnNlcnQuZ28=) | `57.07% <71.42%> (+2.55%)` | :arrow_up: | | [cache\_lru.go](https://codecov.io/gh/go-xorm/xorm/pull/703?src=pr&el=tree#diff-Y2FjaGVfbHJ1Lmdv) | `59.88% <83.33%> (+21.71%)` | :arrow_up: | | [xorm.go](https://codecov.io/gh/go-xorm/xorm/pull/703?src=pr&el=tree#diff-eG9ybS5nbw==) | `64.78% <0%> (-2.82%)` | :arrow_down: | | ... and [7 more](https://codecov.io/gh/go-xorm/xorm/pull/703?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/703?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/703?src=pr&el=footer). Last update [763e1b2...97fc1d9](https://codecov.io/gh/go-xorm/xorm/pull/703?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny commented

2017-09-09 03:04:06 +00:00

fixed #707, fixed #708