refactor for value2String #713

lunny · 2017-09-09T11:12:39Z

lunny commented

2017-09-09 11:12:39 +00:00

No description provided.

codecov-io commented

2017-09-09 11:21:05 +00:00

(Migrated from github.com)

Codecov Report

Merging #713 into master will decrease coverage by 0.01%.
The diff coverage is 80%.

@@            Coverage Diff            @@
##           master    #713      +/-   ##
=========================================
- Coverage   52.11%   52.1%   -0.02%     
=========================================
  Files          35      35              
  Lines        8234    8226       -8     
=========================================
- Hits         4291    4286       -5     
+ Misses       3455    3453       -2     
+ Partials      488     487       -1

Impacted Files	Coverage Δ
session_query.go	`59.01% <100%> (+0.42%)`	⬆️
session_raw.go	`58.27% <75%> (-0.6%)`	⬇️
xorm.go	`66.19% <0%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9eb2f5...0a9c234. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/713?src=pr&el=h1) Report > Merging [#713](https://codecov.io/gh/go-xorm/xorm/pull/713?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/d9eb2f5f36409ce2c014fd7f44cd123d1d8e32c8?src=pr&el=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `80%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/713/graphs/tree.svg?token=yB5nO1krEe&height=150&src=pr&width=650)](https://codecov.io/gh/go-xorm/xorm/pull/713?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #713 +/- ## ========================================= - Coverage 52.11% 52.1% -0.02% ========================================= Files 35 35 Lines 8234 8226 -8 ========================================= - Hits 4291 4286 -5 + Misses 3455 3453 -2 + Partials 488 487 -1 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/713?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [session\_query.go](https://codecov.io/gh/go-xorm/xorm/pull/713?src=pr&el=tree#diff-c2Vzc2lvbl9xdWVyeS5nbw==) | `59.01% <100%> (+0.42%)` | :arrow_up: | | [session\_raw.go](https://codecov.io/gh/go-xorm/xorm/pull/713?src=pr&el=tree#diff-c2Vzc2lvbl9yYXcuZ28=) | `58.27% <75%> (-0.6%)` | :arrow_down: | | [xorm.go](https://codecov.io/gh/go-xorm/xorm/pull/713?src=pr&el=tree#diff-eG9ybS5nbw==) | `66.19% <0%> (ø)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/713?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/713?src=pr&el=footer). Last update [d9eb2f5...0a9c234](https://codecov.io/gh/go-xorm/xorm/pull/713?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny referenced this issue from a commit

2019-10-21 05:47:00 +00:00

refactor for value2String (#713)

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#713