fix bugs on Get #718

lunny · 2017-09-10T12:39:21Z

lunny commented

2017-09-10 12:39:21 +00:00

As title.

codecov-io commented

2017-09-10 12:57:16 +00:00

(Migrated from github.com)

Codecov Report

Merging #718 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #718      +/-   ##
=========================================
+ Coverage   52.37%   52.4%   +0.03%     
=========================================
  Files          35      35              
  Lines        8226    8225       -1     
=========================================
+ Hits         4308    4310       +2     
+ Misses       3433    3431       -2     
+ Partials      485     484       -1

Impacted Files	Coverage Δ
xorm.go	`66.19% <ø> (ø)`	⬆️
session_get.go	`73.54% <100%> (+1.75%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e4538d...3971d42. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/718?src=pr&el=h1) Report > Merging [#718](https://codecov.io/gh/go-xorm/xorm/pull/718?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/4e4538d99a600391f680dd7c27e089b0cf18cc95?src=pr&el=desc) will **increase** coverage by `0.03%`. > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/718/graphs/tree.svg?token=yB5nO1krEe&width=650&src=pr&height=150)](https://codecov.io/gh/go-xorm/xorm/pull/718?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #718 +/- ## ========================================= + Coverage 52.37% 52.4% +0.03% ========================================= Files 35 35 Lines 8226 8225 -1 ========================================= + Hits 4308 4310 +2 + Misses 3433 3431 -2 + Partials 485 484 -1 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/718?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [xorm.go](https://codecov.io/gh/go-xorm/xorm/pull/718?src=pr&el=tree#diff-eG9ybS5nbw==) | `66.19% <ø> (ø)` | :arrow_up: | | [session\_get.go](https://codecov.io/gh/go-xorm/xorm/pull/718?src=pr&el=tree#diff-c2Vzc2lvbl9nZXQuZ28=) | `73.54% <100%> (+1.75%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/718?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/718?src=pr&el=footer). Last update [4e4538d...3971d42](https://codecov.io/gh/go-xorm/xorm/pull/718?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny referenced this issue from a commit

2019-10-21 05:47:00 +00:00

fix bugs on Get (#718)

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#718