add string support #730

lunny · 2017-09-20T09:29:34Z

leafsoar commented

2017-09-20 09:29:34 +00:00

(Migrated from github.com)

数据库中的 json 理应被 golang 端的 string 类型支持，以前使用 xorm 生成的对象就是 json 映射到 golang string 类型的。

codecov-io commented

2017-09-20 09:39:13 +00:00

(Migrated from github.com)

Codecov Report

Merging #730 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #730      +/-   ##
==========================================
- Coverage    51.3%   51.29%   -0.01%     
==========================================
  Files          38       38              
  Lines        8526     8529       +3     
==========================================
+ Hits         4374     4375       +1     
- Misses       3669     3672       +3     
+ Partials      483      482       -1

Impacted Files	Coverage Δ
session.go	`53.56% <0%> (-0.27%)`	⬇️
xorm.go	`67.6% <0%> (+1.4%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 165dd98...1c8029c. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/730?src=pr&el=h1) Report > Merging [#730](https://codecov.io/gh/go-xorm/xorm/pull/730?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/165dd989d0c7cd196b5625222e14ca4bb683af56?src=pr&el=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `0%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/730/graphs/tree.svg?height=150&width=650&token=yB5nO1krEe&src=pr)](https://codecov.io/gh/go-xorm/xorm/pull/730?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #730 +/- ## ========================================== - Coverage 51.3% 51.29% -0.01% ========================================== Files 38 38 Lines 8526 8529 +3 ========================================== + Hits 4374 4375 +1 - Misses 3669 3672 +3 + Partials 483 482 -1 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/730?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [session.go](https://codecov.io/gh/go-xorm/xorm/pull/730?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `53.56% <0%> (-0.27%)` | :arrow_down: | | [xorm.go](https://codecov.io/gh/go-xorm/xorm/pull/730?src=pr&el=tree#diff-eG9ybS5nbw==) | `67.6% <0%> (+1.4%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/730?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/730?src=pr&el=footer). Last update [165dd98...1c8029c](https://codecov.io/gh/go-xorm/xorm/pull/730?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny commented

2017-09-20 10:40:43 +00:00

Hi, could you add some tests for this?

lunny referenced this issue from a commit

2019-10-21 05:47:00 +00:00

add string support (#730)

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#730