Add support Engine Group #748

lunny · 2017-10-16T06:36:33Z

lunny commented

2017-10-16 06:36:33 +00:00

Will replace #741 since #741 has a different code base.

codecov-io commented

2017-10-16 06:52:41 +00:00

(Migrated from github.com)

Codecov Report

Merging #748 into master will decrease coverage by 1.34%.
The diff coverage is 13.3%.

@@            Coverage Diff            @@
##           master    #748      +/-   ##
=========================================
- Coverage   52.64%   51.3%   -1.35%     
=========================================
  Files          36      38       +2     
  Lines        8310    8526     +216     
=========================================
- Hits         4375    4374       -1     
- Misses       3448    3669     +221     
+ Partials      487     483       -4

Impacted Files	Coverage Δ
engine_group.go	`0% <0%> (ø)`
engine_maxlife.go	`0% <0%> (ø)`	⬆️
engine_group_policy.go	`0% <0%> (ø)`
session.go	`53.83% <100%> (+0.07%)`	⬆️
session_raw.go	`57.93% <55.55%> (-0.35%)`	⬇️
engine.go	`56.14% <82.14%> (-0.59%)`	⬇️
xorm.go	`66.19% <0%> (-1.41%)`	⬇️
session_schema.go	`51.76% <0%> (-1.29%)`	⬇️
helpers.go	`61.06% <0%> (-0.85%)`	⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29d4a03...dbb2220. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/748?src=pr&el=h1) Report > Merging [#748](https://codecov.io/gh/go-xorm/xorm/pull/748?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/29d4a0330a00b9be468b70e3fb0f74109348c358?src=pr&el=desc) will **decrease** coverage by `1.34%`. > The diff coverage is `13.3%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/748/graphs/tree.svg?width=650&src=pr&token=yB5nO1krEe&height=150)](https://codecov.io/gh/go-xorm/xorm/pull/748?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #748 +/- ## ========================================= - Coverage 52.64% 51.3% -1.35% ========================================= Files 36 38 +2 Lines 8310 8526 +216 ========================================= - Hits 4375 4374 -1 - Misses 3448 3669 +221 + Partials 487 483 -4 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/748?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [engine\_group.go](https://codecov.io/gh/go-xorm/xorm/pull/748?src=pr&el=tree#diff-ZW5naW5lX2dyb3VwLmdv) | `0% <0%> (ø)` | | | [engine\_maxlife.go](https://codecov.io/gh/go-xorm/xorm/pull/748?src=pr&el=tree#diff-ZW5naW5lX21heGxpZmUuZ28=) | `0% <0%> (ø)` | :arrow_up: | | [engine\_group\_policy.go](https://codecov.io/gh/go-xorm/xorm/pull/748?src=pr&el=tree#diff-ZW5naW5lX2dyb3VwX3BvbGljeS5nbw==) | `0% <0%> (ø)` | | | [session.go](https://codecov.io/gh/go-xorm/xorm/pull/748?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `53.83% <100%> (+0.07%)` | :arrow_up: | | [session\_raw.go](https://codecov.io/gh/go-xorm/xorm/pull/748?src=pr&el=tree#diff-c2Vzc2lvbl9yYXcuZ28=) | `57.93% <55.55%> (-0.35%)` | :arrow_down: | | [engine.go](https://codecov.io/gh/go-xorm/xorm/pull/748?src=pr&el=tree#diff-ZW5naW5lLmdv) | `56.14% <82.14%> (-0.59%)` | :arrow_down: | | [xorm.go](https://codecov.io/gh/go-xorm/xorm/pull/748?src=pr&el=tree#diff-eG9ybS5nbw==) | `66.19% <0%> (-1.41%)` | :arrow_down: | | [session\_schema.go](https://codecov.io/gh/go-xorm/xorm/pull/748?src=pr&el=tree#diff-c2Vzc2lvbl9zY2hlbWEuZ28=) | `51.76% <0%> (-1.29%)` | :arrow_down: | | [helpers.go](https://codecov.io/gh/go-xorm/xorm/pull/748?src=pr&el=tree#diff-aGVscGVycy5nbw==) | `61.06% <0%> (-0.85%)` | :arrow_down: | | ... and [2 more](https://codecov.io/gh/go-xorm/xorm/pull/748?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/748?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/748?src=pr&el=footer). Last update [29d4a03...dbb2220](https://codecov.io/gh/go-xorm/xorm/pull/748?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny commented

2017-10-16 07:27:42 +00:00

will resolve #78

lunny referenced this issue from a commit

2019-10-21 05:47:00 +00:00

Add support Engine Group (#748) * add support group engine * revert code * add NewGroup function * add engine group policy * rename file name * modify policy interface * remove Init function from policy interface * refactor Group Policy * rename and comments * rename and bug fix for WeightRoundRobinPolicy * modify Slave function * modify Slave function and add LeastConnPolicy * use original Engine and Session * remove unused count variables * fix bug on NewEngineGroup * remove unused method * improve range and refactor * add some comments and refactor * implement GroupPolicy of GroupPolicyHandler * refactor * simple code * add tests support for EngineGroup & fix some bugs * improve the NewEngineGroup interface * change the default policy of engine group * fix some tests

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#748