after call AfterInsert #750

lunny · 2017-10-17T07:01:39Z

vlorc commented

2017-10-17 07:01:39 +00:00

(Migrated from github.com)

defer handleAfterInsertProcessorFunc(bean)

codecov-io commented

2017-10-17 07:21:30 +00:00

(Migrated from github.com)

Codecov Report

Merging #750 into master will increase coverage by 0.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #750      +/-   ##
==========================================
+ Coverage    51.3%   51.31%   +0.01%     
==========================================
  Files          38       38              
  Lines        8526     8526              
==========================================
+ Hits         4374     4375       +1     
  Misses       3669     3669              
+ Partials      483      482       -1

Impacted Files	Coverage Δ
session_insert.go	`57.77% <50%> (ø)`	⬆️
xorm.go	`67.6% <0%> (+1.4%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 109cb1a...399f0e0. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/750?src=pr&el=h1) Report > Merging [#750](https://codecov.io/gh/go-xorm/xorm/pull/750?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/109cb1a7d078588d03255b1ba04b00f89648cc97?src=pr&el=desc) will **increase** coverage by `0.01%`. > The diff coverage is `50%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/750/graphs/tree.svg?width=650&height=150&token=yB5nO1krEe&src=pr)](https://codecov.io/gh/go-xorm/xorm/pull/750?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #750 +/- ## ========================================== + Coverage 51.3% 51.31% +0.01% ========================================== Files 38 38 Lines 8526 8526 ========================================== + Hits 4374 4375 +1 Misses 3669 3669 + Partials 483 482 -1 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/750?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [session\_insert.go](https://codecov.io/gh/go-xorm/xorm/pull/750?src=pr&el=tree#diff-c2Vzc2lvbl9pbnNlcnQuZ28=) | `57.77% <50%> (ø)` | :arrow_up: | | [xorm.go](https://codecov.io/gh/go-xorm/xorm/pull/750?src=pr&el=tree#diff-eG9ybS5nbw==) | `67.6% <0%> (+1.4%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/750?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/750?src=pr&el=footer). Last update [109cb1a...399f0e0](https://codecov.io/gh/go-xorm/xorm/pull/750?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny commented

2017-10-20 06:04:53 +00:00

Could you add some tests?

lunny referenced this issue from a commit

2019-10-21 05:47:00 +00:00

after call AfterInsert (#750) defer handleAfterInsertProcessorFunc(bean)

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#750