Improve error string & fix #789 #790

lunny · 2017-12-02T06:03:06Z

lunny commented

2017-12-02 06:03:06 +00:00

No description provided.

codecov-io commented

2017-12-02 06:21:04 +00:00

(Migrated from github.com)

Codecov Report

Merging #790 into master will increase coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #790      +/-   ##
==========================================
+ Coverage   53.18%   53.19%   +0.01%     
==========================================
  Files          39       39              
  Lines        7326     7326              
==========================================
+ Hits         3896     3897       +1     
  Misses       2935     2935              
+ Partials      495      494       -1

Impacted Files	Coverage Δ
engine.go	`58.67% <0%> (ø)`	⬆️
xorm.go	`70% <0%> (+1.66%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16930c1...ba8f4ae. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/790?src=pr&el=h1) Report > Merging [#790](https://codecov.io/gh/go-xorm/xorm/pull/790?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/16930c1be77d1bcbd3407d9545f295370c91419d?src=pr&el=desc) will **increase** coverage by `0.01%`. > The diff coverage is `0%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/790/graphs/tree.svg?height=150&width=650&token=yB5nO1krEe&src=pr)](https://codecov.io/gh/go-xorm/xorm/pull/790?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #790 +/- ## ========================================== + Coverage 53.18% 53.19% +0.01% ========================================== Files 39 39 Lines 7326 7326 ========================================== + Hits 3896 3897 +1 Misses 2935 2935 + Partials 495 494 -1 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/790?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [engine.go](https://codecov.io/gh/go-xorm/xorm/pull/790/diff?src=pr&el=tree#diff-ZW5naW5lLmdv) | `58.67% <0%> (ø)` | :arrow_up: | | [xorm.go](https://codecov.io/gh/go-xorm/xorm/pull/790/diff?src=pr&el=tree#diff-eG9ybS5nbw==) | `70% <0%> (+1.66%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/790?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/790?src=pr&el=footer). Last update [16930c1...ba8f4ae](https://codecov.io/gh/go-xorm/xorm/pull/790?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny referenced this issue from a commit

2019-10-21 05:47:00 +00:00

improve error string & fix #789 (#790)

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#790