Improve schema support on postgres dialect #845

lunny · 2018-02-08T10:12:28Z

lunny commented

2018-02-08 10:12:28 +00:00

No description provided.

codecov-io commented

2018-02-08 10:17:39 +00:00

(Migrated from github.com)

Codecov Report

Merging #845 into master will decrease coverage by 0.02%.
The diff coverage is 57.77%.

@@            Coverage Diff            @@
##           master    #845      +/-   ##
=========================================
- Coverage   53.23%   53.2%   -0.03%     
=========================================
  Files          39      39              
  Lines        7356    7384      +28     
=========================================
+ Hits         3916    3929      +13     
- Misses       2940    2952      +12     
- Partials      500     503       +3

Impacted Files	Coverage Δ
dialect_postgres.go	`74.91% <57.77%> (-2.95%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 430fbe8...b4af556. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/845?src=pr&el=h1) Report > Merging [#845](https://codecov.io/gh/go-xorm/xorm/pull/845?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/430fbe866a716bac8e5307d0c5222346f37cf8cf?src=pr&el=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `57.77%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/845/graphs/tree.svg?width=650&height=150&token=yB5nO1krEe&src=pr)](https://codecov.io/gh/go-xorm/xorm/pull/845?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #845 +/- ## ========================================= - Coverage 53.23% 53.2% -0.03% ========================================= Files 39 39 Lines 7356 7384 +28 ========================================= + Hits 3916 3929 +13 - Misses 2940 2952 +12 - Partials 500 503 +3 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/845?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [dialect\_postgres.go](https://codecov.io/gh/go-xorm/xorm/pull/845/diff?src=pr&el=tree#diff-ZGlhbGVjdF9wb3N0Z3Jlcy5nbw==) | `74.91% <57.77%> (-2.95%)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/845?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/845?src=pr&el=footer). Last update [430fbe8...b4af556](https://codecov.io/gh/go-xorm/xorm/pull/845?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny referenced this issue from a commit

2019-10-21 05:47:00 +00:00

Improve schema support on postgres dialect (#845) * add schema on postgres dialect * fix to support no specific schema when postgres

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#845