fix findandcount bug with order #869

lunny · 2018-03-26T02:06:56Z

lunny commented

2018-03-26 02:06:56 +00:00

Will fix #864

codecov-io commented

2018-03-26 02:21:32 +00:00

(Migrated from github.com)

Codecov Report

Merging #869 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #869      +/-   ##
==========================================
- Coverage   53.27%   53.27%   -0.01%     
==========================================
  Files          39       39              
  Lines        7448     7450       +2     
==========================================
+ Hits         3968     3969       +1     
  Misses       2977     2977              
- Partials      503      504       +1

Impacted Files	Coverage Δ
session_find.go	`66.87% <100%> (+0.21%)`	⬆️
xorm.go	`64.06% <0%> (-1.57%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18b1524...7865fcb. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/869?src=pr&el=h1) Report > Merging [#869](https://codecov.io/gh/go-xorm/xorm/pull/869?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/18b1524be43f30ce0c64b036af5ffc0361bbfa0c?src=pr&el=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/869/graphs/tree.svg?height=150&src=pr&width=650&token=yB5nO1krEe)](https://codecov.io/gh/go-xorm/xorm/pull/869?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #869 +/- ## ========================================== - Coverage 53.27% 53.27% -0.01% ========================================== Files 39 39 Lines 7448 7450 +2 ========================================== + Hits 3968 3969 +1 Misses 2977 2977 - Partials 503 504 +1 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/869?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [session\_find.go](https://codecov.io/gh/go-xorm/xorm/pull/869/diff?src=pr&el=tree#diff-c2Vzc2lvbl9maW5kLmdv) | `66.87% <100%> (+0.21%)` | :arrow_up: | | [xorm.go](https://codecov.io/gh/go-xorm/xorm/pull/869/diff?src=pr&el=tree#diff-eG9ybS5nbw==) | `64.06% <0%> (-1.57%)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/869?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/869?src=pr&el=footer). Last update [18b1524...7865fcb](https://codecov.io/gh/go-xorm/xorm/pull/869?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny referenced this issue from a commit

2019-10-21 05:47:00 +00:00

fix findandcount bug with order (#869)

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#869