Add SetSchema for engine #876

lunny · 2018-04-08T15:23:24Z

lunny commented

2018-04-08 15:23:24 +00:00

No description provided.

codecov-io commented

2018-04-09 06:40:46 +00:00

(Migrated from github.com)

Codecov Report

Merging #876 into master will increase coverage by 0.12%.
The diff coverage is 69.93%.

@@            Coverage Diff             @@
##           master     #876      +/-   ##
==========================================
+ Coverage   53.42%   53.55%   +0.12%     
==========================================
  Files          39       40       +1     
  Lines        7472     7464       -8     
==========================================
+ Hits         3992     3997       +5     
+ Misses       2975     2965      -10     
+ Partials      505      502       -3

Impacted Files	Coverage Δ
session.go	`56.34% <ø> (-0.35%)`	⬇️
session_update.go	`52.14% <0%> (ø)`	⬆️
session_delete.go	`58.97% <0%> (ø)`	⬆️
session_insert.go	`58.26% <0%> (ø)`	⬆️
session_get.go	`75.57% <0%> (ø)`	⬆️
session_exist.go	`57.44% <0%> (ø)`	⬆️
dialect_postgres.go	`75.24% <100%> (+0.33%)`	⬆️
rows.go	`50.76% <33.33%> (ø)`	⬆️
engine.go	`58.17% <41.17%> (-0.78%)`	⬇️
session_schema.go	`57.14% <46.66%> (-0.38%)`	⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b84179...ea6ebc3. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/876?src=pr&el=h1) Report > Merging [#876](https://codecov.io/gh/go-xorm/xorm/pull/876?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/0b841796fa51b91b58f1ca2da65cf4b5af470c75?src=pr&el=desc) will **increase** coverage by `0.12%`. > The diff coverage is `69.93%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/876/graphs/tree.svg?token=yB5nO1krEe&src=pr&height=150&width=650)](https://codecov.io/gh/go-xorm/xorm/pull/876?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #876 +/- ## ========================================== + Coverage 53.42% 53.55% +0.12% ========================================== Files 39 40 +1 Lines 7472 7464 -8 ========================================== + Hits 3992 3997 +5 + Misses 2975 2965 -10 + Partials 505 502 -3 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/876?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [session.go](https://codecov.io/gh/go-xorm/xorm/pull/876/diff?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `56.34% <ø> (-0.35%)` | :arrow_down: | | [session\_update.go](https://codecov.io/gh/go-xorm/xorm/pull/876/diff?src=pr&el=tree#diff-c2Vzc2lvbl91cGRhdGUuZ28=) | `52.14% <0%> (ø)` | :arrow_up: | | [session\_delete.go](https://codecov.io/gh/go-xorm/xorm/pull/876/diff?src=pr&el=tree#diff-c2Vzc2lvbl9kZWxldGUuZ28=) | `58.97% <0%> (ø)` | :arrow_up: | | [session\_insert.go](https://codecov.io/gh/go-xorm/xorm/pull/876/diff?src=pr&el=tree#diff-c2Vzc2lvbl9pbnNlcnQuZ28=) | `58.26% <0%> (ø)` | :arrow_up: | | [session\_get.go](https://codecov.io/gh/go-xorm/xorm/pull/876/diff?src=pr&el=tree#diff-c2Vzc2lvbl9nZXQuZ28=) | `75.57% <0%> (ø)` | :arrow_up: | | [session\_exist.go](https://codecov.io/gh/go-xorm/xorm/pull/876/diff?src=pr&el=tree#diff-c2Vzc2lvbl9leGlzdC5nbw==) | `57.44% <0%> (ø)` | :arrow_up: | | [dialect\_postgres.go](https://codecov.io/gh/go-xorm/xorm/pull/876/diff?src=pr&el=tree#diff-ZGlhbGVjdF9wb3N0Z3Jlcy5nbw==) | `75.24% <100%> (+0.33%)` | :arrow_up: | | [rows.go](https://codecov.io/gh/go-xorm/xorm/pull/876/diff?src=pr&el=tree#diff-cm93cy5nbw==) | `50.76% <33.33%> (ø)` | :arrow_up: | | [engine.go](https://codecov.io/gh/go-xorm/xorm/pull/876/diff?src=pr&el=tree#diff-ZW5naW5lLmdv) | `58.17% <41.17%> (-0.78%)` | :arrow_down: | | [session\_schema.go](https://codecov.io/gh/go-xorm/xorm/pull/876/diff?src=pr&el=tree#diff-c2Vzc2lvbl9zY2hlbWEuZ28=) | `57.14% <46.66%> (-0.38%)` | :arrow_down: | | ... and [4 more](https://codecov.io/gh/go-xorm/xorm/pull/876/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/876?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/876?src=pr&el=footer). Last update [0b84179...ea6ebc3](https://codecov.io/gh/go-xorm/xorm/pull/876?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny commented

2018-04-09 15:24:19 +00:00

will fix #361

lunny referenced this issue from a commit

2019-10-21 05:47:00 +00:00

Add SetSchema for engine (#876) * add SetSchema for engine * fix user * fix postgres with schema * fix test * fix test * fix test * fix tablename * refactor tableName * fix schema support * improve the interface of EngineInterface

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#876