add test and remove unused warn log #886

lunny · 2018-04-11T05:36:38Z

lunny commented

2018-04-11 05:36:38 +00:00

to confirm #868

codecov-io commented

2018-04-11 06:09:33 +00:00

(Migrated from github.com)

Codecov Report

Merging #886 into master will increase coverage by 0.08%.
The diff coverage is 39.17%.

@@            Coverage Diff             @@
##           master     #886      +/-   ##
==========================================
+ Coverage   53.55%   53.63%   +0.08%     
==========================================
  Files          40       41       +1     
  Lines        7527     7534       +7     
==========================================
+ Hits         4031     4041      +10     
+ Misses       2983     2979       -4     
- Partials      513      514       +1

Impacted Files	Coverage Δ
error.go	`0% <0%> (ø)`
engine_cond.go	`54.96% <0%> (+0.96%)`	⬆️
session.go	`56.69% <39.72%> (+0.34%)`	⬆️
engine.go	`58.62% <0%> (+0.45%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8ae6fa...65c7bc1. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/886?src=pr&el=h1) Report > Merging [#886](https://codecov.io/gh/go-xorm/xorm/pull/886?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/c8ae6fa95b6cc8c5c674d5034500b852468aacdb?src=pr&el=desc) will **increase** coverage by `0.08%`. > The diff coverage is `39.17%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/886/graphs/tree.svg?width=650&height=150&src=pr&token=yB5nO1krEe)](https://codecov.io/gh/go-xorm/xorm/pull/886?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #886 +/- ## ========================================== + Coverage 53.55% 53.63% +0.08% ========================================== Files 40 41 +1 Lines 7527 7534 +7 ========================================== + Hits 4031 4041 +10 + Misses 2983 2979 -4 - Partials 513 514 +1 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/886?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [error.go](https://codecov.io/gh/go-xorm/xorm/pull/886/diff?src=pr&el=tree#diff-ZXJyb3IuZ28=) | `0% <0%> (ø)` | | | [engine\_cond.go](https://codecov.io/gh/go-xorm/xorm/pull/886/diff?src=pr&el=tree#diff-ZW5naW5lX2NvbmQuZ28=) | `54.96% <0%> (+0.96%)` | :arrow_up: | | [session.go](https://codecov.io/gh/go-xorm/xorm/pull/886/diff?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `56.69% <39.72%> (+0.34%)` | :arrow_up: | | [engine.go](https://codecov.io/gh/go-xorm/xorm/pull/886/diff?src=pr&el=tree#diff-ZW5naW5lLmdv) | `58.62% <0%> (+0.45%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/886?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/886?src=pr&el=footer). Last update [c8ae6fa...65c7bc1](https://codecov.io/gh/go-xorm/xorm/pull/886?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny referenced this issue from a commit

2019-10-21 05:47:01 +00:00

add test and remove unused warn log (#886)

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#886