Add more test for join find #922

lunny · 2018-05-02T09:25:16Z

lunny commented

2018-05-02 09:25:16 +00:00

more tests and detailed error

codecov-io commented

2018-05-02 09:52:20 +00:00

(Migrated from github.com)

Codecov Report

Merging #922 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #922      +/-   ##
==========================================
- Coverage   54.11%   54.09%   -0.03%     
==========================================
  Files          41       41              
  Lines        7537     7539       +2     
==========================================
- Hits         4079     4078       -1     
- Misses       2942     2943       +1     
- Partials      516      518       +2

Impacted Files	Coverage Δ
session.go	`56.29% <100%> (-0.4%)`	⬇️
error.go	`50% <100%> (+50%)`	⬆️
xorm.go	`64.61% <0%> (-1.54%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a491afa...6a7d8ba. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/922?src=pr&el=h1) Report > Merging [#922](https://codecov.io/gh/go-xorm/xorm/pull/922?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/a491afac1818b9a894205b5b35e2692d5ce58cea?src=pr&el=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/922/graphs/tree.svg?src=pr&token=yB5nO1krEe&width=650&height=150)](https://codecov.io/gh/go-xorm/xorm/pull/922?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #922 +/- ## ========================================== - Coverage 54.11% 54.09% -0.03% ========================================== Files 41 41 Lines 7537 7539 +2 ========================================== - Hits 4079 4078 -1 - Misses 2942 2943 +1 - Partials 516 518 +2 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/922?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [session.go](https://codecov.io/gh/go-xorm/xorm/pull/922/diff?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `56.29% <100%> (-0.4%)` | :arrow_down: | | [error.go](https://codecov.io/gh/go-xorm/xorm/pull/922/diff?src=pr&el=tree#diff-ZXJyb3IuZ28=) | `50% <100%> (+50%)` | :arrow_up: | | [xorm.go](https://codecov.io/gh/go-xorm/xorm/pull/922/diff?src=pr&el=tree#diff-eG9ybS5nbw==) | `64.61% <0%> (-1.54%)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/922?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/922?src=pr&el=footer). Last update [a491afa...6a7d8ba](https://codecov.io/gh/go-xorm/xorm/pull/922?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny referenced this issue from a commit

2019-10-21 05:47:01 +00:00

add more test for join find (#922)

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#922