fix statement.LimitN(0) will delete or update all data #1119

lunny · 2018-10-17T05:03:17Z

Frank-Hust commented

2018-10-17 05:03:17 +00:00

(Migrated from github.com)

change LimitN from int to *int.

Frank-Hust commented

2018-10-17 05:04:13 +00:00

(Migrated from github.com)

#1117

codecov-io commented

2018-10-17 05:25:18 +00:00

(Migrated from github.com)

Codecov Report

Merging #1119 into master will decrease coverage by 0.01%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##           master    #1119      +/-   ##
==========================================
- Coverage   54.64%   54.63%   -0.02%     
==========================================
  Files          42       42              
  Lines        7640     7649       +9     
==========================================
+ Hits         4175     4179       +4     
- Misses       2937     2940       +3     
- Partials      528      530       +2

Impacted Files	Coverage Δ
session_iterate.go	`80% <100%> (ø)`	⬆️
session_delete.go	`58.86% <20%> (-0.12%)`	⬇️
statement.go	`66.75% <47.05%> (-0.14%)`	⬇️
session_update.go	`52.69% <71.42%> (+0.15%)`	⬆️
xorm.go	`64.61% <0%> (-1.54%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a7b211...da2991a. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1119?src=pr&el=h1) Report > Merging [#1119](https://codecov.io/gh/go-xorm/xorm/pull/1119?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/1a7b21155bea2ad3039ec38c579bc154d6e1fba6?src=pr&el=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `57.14%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/1119/graphs/tree.svg?width=650&token=yB5nO1krEe&height=150&src=pr)](https://codecov.io/gh/go-xorm/xorm/pull/1119?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1119 +/- ## ========================================== - Coverage 54.64% 54.63% -0.02% ========================================== Files 42 42 Lines 7640 7649 +9 ========================================== + Hits 4175 4179 +4 - Misses 2937 2940 +3 - Partials 528 530 +2 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/1119?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [session\_iterate.go](https://codecov.io/gh/go-xorm/xorm/pull/1119/diff?src=pr&el=tree#diff-c2Vzc2lvbl9pdGVyYXRlLmdv) | `80% <100%> (ø)` | :arrow_up: | | [session\_delete.go](https://codecov.io/gh/go-xorm/xorm/pull/1119/diff?src=pr&el=tree#diff-c2Vzc2lvbl9kZWxldGUuZ28=) | `58.86% <20%> (-0.12%)` | :arrow_down: | | [statement.go](https://codecov.io/gh/go-xorm/xorm/pull/1119/diff?src=pr&el=tree#diff-c3RhdGVtZW50Lmdv) | `66.75% <47.05%> (-0.14%)` | :arrow_down: | | [session\_update.go](https://codecov.io/gh/go-xorm/xorm/pull/1119/diff?src=pr&el=tree#diff-c2Vzc2lvbl91cGRhdGUuZ28=) | `52.69% <71.42%> (+0.15%)` | :arrow_up: | | [xorm.go](https://codecov.io/gh/go-xorm/xorm/pull/1119/diff?src=pr&el=tree#diff-eG9ybS5nbw==) | `64.61% <0%> (-1.54%)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1119?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1119?src=pr&el=footer). Last update [1a7b211...da2991a](https://codecov.io/gh/go-xorm/xorm/pull/1119?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny modified the milestone from 0.8 to 0.8.2

2019-10-21 03:49:16 +00:00

lunny referenced this issue from a commit

2020-01-20 08:22:08 +00:00

lunny closed this pull request

2020-01-20 08:22:10 +00:00

lunny deleted branch Frank-Hust/master

2020-01-20 08:22:18 +00:00

lunny referenced this pull request

2020-01-20 08:23:04 +00:00

limitN = 0 的时候，相当于没有限制。 #1117

lunny referenced this pull request