Fix mssql issue with duplicate columns. #1225

Merged
Neopallium merged 3 commits from Neopallium/master into master 2 years ago
Neopallium commented 3 years ago (Migrated from github.com)
Owner

The GetColumns() method for the mssql dialect can return the same
column multiple times if the column is in multiple indexes.

The `GetColumns()` method for the mssql dialect can return the same column multiple times if the column is in multiple indexes.
codecov-io commented 3 years ago (Migrated from github.com)
Owner

Codecov Report

Merging #1225 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1225      +/-   ##
=========================================
+ Coverage   57.35%   57.4%   +0.04%     
=========================================
  Files          43      43              
  Lines        7797    7794       -3     
=========================================
+ Hits         4472    4474       +2     
+ Misses       2771    2769       -2     
+ Partials      554     551       -3
Impacted Files Coverage Δ
dialect_mssql.go 74.11% <100%> (+0.1%) ⬆️
xorm.go 68.18% <0%> (-1.52%) ⬇️
session_exist.go 71.42% <0%> (+9.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e410f04...22568ea. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1225?src=pr&el=h1) Report > Merging [#1225](https://codecov.io/gh/go-xorm/xorm/pull/1225?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/e410f04aaf2db78083222488e35a0cff3b0ca2f1?src=pr&el=desc) will **increase** coverage by `0.04%`. > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/1225/graphs/tree.svg?width=650&token=yB5nO1krEe&height=150&src=pr)](https://codecov.io/gh/go-xorm/xorm/pull/1225?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1225 +/- ## ========================================= + Coverage 57.35% 57.4% +0.04% ========================================= Files 43 43 Lines 7797 7794 -3 ========================================= + Hits 4472 4474 +2 + Misses 2771 2769 -2 + Partials 554 551 -3 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/1225?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [dialect\_mssql.go](https://codecov.io/gh/go-xorm/xorm/pull/1225/diff?src=pr&el=tree#diff-ZGlhbGVjdF9tc3NxbC5nbw==) | `74.11% <100%> (+0.1%)` | :arrow_up: | | [xorm.go](https://codecov.io/gh/go-xorm/xorm/pull/1225/diff?src=pr&el=tree#diff-eG9ybS5nbw==) | `68.18% <0%> (-1.52%)` | :arrow_down: | | [session\_exist.go](https://codecov.io/gh/go-xorm/xorm/pull/1225/diff?src=pr&el=tree#diff-c2Vzc2lvbl9leGlzdC5nbw==) | `71.42% <0%> (+9.16%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1225?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1225?src=pr&el=footer). Last update [e410f04...22568ea](https://codecov.io/gh/go-xorm/xorm/pull/1225?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
Owner

Thanks @Neopallium . Could you write some test cases for these changes?

Thanks @Neopallium . Could you write some test cases for these changes?
lunny added this to the 1.0.0 milestone 2 years ago
lunny modified the milestone from 1.0.0 to 1.1.1 2 years ago
lunny modified the milestone from 1.1.1 to 1.0.0 2 years ago
lunny closed this pull request 2 years ago
continuous-integration/drone/pr Build is passing
continuous-integration/drone/push Build is passing
The pull request has been merged as 9d4594632f.
Sign in to join this conversation.
Loading…
There is no content yet.