improve tests #1250

lunny · 2019-03-13T11:20:11Z

lunny commented

2019-03-13 11:20:11 +00:00

No description provided.

codecov-io commented

2019-03-13 14:16:44 +00:00

(Migrated from github.com)

Codecov Report

Merging #1250 into master will increase coverage by 0.36%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1250      +/-   ##
==========================================
+ Coverage   57.01%   57.38%   +0.36%     
==========================================
  Files          48       43       -5     
  Lines        8185     7807     -378     
==========================================
- Hits         4667     4480     -187     
+ Misses       2907     2772     -135     
+ Partials      611      555      -56

Impacted Files	Coverage Δ
logger.go	`60.86% <0%> (-5.8%)`	⬇️
rows.go	`52.38% <0%> (-3.76%)`	⬇️
dialect_sqlite3.go	`77.29% <0%> (-2.44%)`	⬇️
tag.go	`77.09% <0%> (-2.36%)`	⬇️
helpers.go	`57.41% <0%> (-2.32%)`	⬇️
dialect_mssql.go	`74.01% <0%> (-1.39%)`	⬇️
engine.go	`61.53% <0%> (-1.31%)`	⬇️
session_schema.go	`59.12% <0%> (-1.2%)`	⬇️
session_exist.go	`62.26% <0%> (-0.7%)`	⬇️
session_update.go	`56.44% <0%> (-0.15%)`	⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5702e5...f524836. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1250?src=pr&el=h1) Report > Merging [#1250](https://codecov.io/gh/go-xorm/xorm/pull/1250?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/a5702e52b51afdace44bfc286a353a3afb0ee3c6?src=pr&el=desc) will **increase** coverage by `0.36%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/1250/graphs/tree.svg?width=650&token=yB5nO1krEe&height=150&src=pr)](https://codecov.io/gh/go-xorm/xorm/pull/1250?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1250 +/- ## ========================================== + Coverage 57.01% 57.38% +0.36% ========================================== Files 48 43 -5 Lines 8185 7807 -378 ========================================== - Hits 4667 4480 -187 + Misses 2907 2772 -135 + Partials 611 555 -56 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/1250?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [logger.go](https://codecov.io/gh/go-xorm/xorm/pull/1250/diff?src=pr&el=tree#diff-bG9nZ2VyLmdv) | `60.86% <0%> (-5.8%)` | :arrow_down: | | [rows.go](https://codecov.io/gh/go-xorm/xorm/pull/1250/diff?src=pr&el=tree#diff-cm93cy5nbw==) | `52.38% <0%> (-3.76%)` | :arrow_down: | | [dialect\_sqlite3.go](https://codecov.io/gh/go-xorm/xorm/pull/1250/diff?src=pr&el=tree#diff-ZGlhbGVjdF9zcWxpdGUzLmdv) | `77.29% <0%> (-2.44%)` | :arrow_down: | | [tag.go](https://codecov.io/gh/go-xorm/xorm/pull/1250/diff?src=pr&el=tree#diff-dGFnLmdv) | `77.09% <0%> (-2.36%)` | :arrow_down: | | [helpers.go](https://codecov.io/gh/go-xorm/xorm/pull/1250/diff?src=pr&el=tree#diff-aGVscGVycy5nbw==) | `57.41% <0%> (-2.32%)` | :arrow_down: | | [dialect\_mssql.go](https://codecov.io/gh/go-xorm/xorm/pull/1250/diff?src=pr&el=tree#diff-ZGlhbGVjdF9tc3NxbC5nbw==) | `74.01% <0%> (-1.39%)` | :arrow_down: | | [engine.go](https://codecov.io/gh/go-xorm/xorm/pull/1250/diff?src=pr&el=tree#diff-ZW5naW5lLmdv) | `61.53% <0%> (-1.31%)` | :arrow_down: | | [session\_schema.go](https://codecov.io/gh/go-xorm/xorm/pull/1250/diff?src=pr&el=tree#diff-c2Vzc2lvbl9zY2hlbWEuZ28=) | `59.12% <0%> (-1.2%)` | :arrow_down: | | [session\_exist.go](https://codecov.io/gh/go-xorm/xorm/pull/1250/diff?src=pr&el=tree#diff-c2Vzc2lvbl9leGlzdC5nbw==) | `62.26% <0%> (-0.7%)` | :arrow_down: | | [session\_update.go](https://codecov.io/gh/go-xorm/xorm/pull/1250/diff?src=pr&el=tree#diff-c2Vzc2lvbl91cGRhdGUuZ28=) | `56.44% <0%> (-0.15%)` | :arrow_down: | | ... and [17 more](https://codecov.io/gh/go-xorm/xorm/pull/1250/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1250?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1250?src=pr&el=footer). Last update [a5702e5...f524836](https://codecov.io/gh/go-xorm/xorm/pull/1250?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny modified the milestone from 0.8 to 0.8.2

2019-10-21 03:49:16 +00:00

lunny modified the milestone from 0.8.2 to 1.3.0

2020-01-20 05:43:29 +00:00

lunny closed this pull request

2021-04-11 09:08:27 +00:00

lunny deleted branch lunny/improve_tests

2021-04-11 09:08:32 +00:00

lunny removed this from the 1.3.0 milestone 2021-04-11 09:08:37 +00:00

continuous-integration/drone/pr Build encountered an error

Details

continuous-integration/drone/push Build is failing

Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#1250