add logger of session #1283

betacat0 · 2019-04-30T07:48:40Z

chenxuey commented

2019-04-30 07:48:40 +00:00

(Migrated from github.com)

每个 session 也可以注入一个日志

codecov-io commented

2019-04-30 07:58:08 +00:00

(Migrated from github.com)

Codecov Report

Merging #1283 into master will decrease coverage by 0.06%.
The diff coverage is 36.76%.

@@            Coverage Diff             @@
##           master    #1283      +/-   ##
==========================================
- Coverage   57.36%   57.29%   -0.07%     
==========================================
  Files          44       44              
  Lines        7817     7824       +7     
==========================================
- Hits         4484     4483       -1     
- Misses       2777     2783       +6     
- Partials      556      558       +2

Impacted Files	Coverage Δ
session_convert.go	`22.29% <0%> (ø)`	⬆️
session_get.go	`75.83% <100%> (ø)`	⬆️
session_context.go	`75% <100%> (ø)`	⬆️
session_delete.go	`58.22% <100%> (ø)`	⬆️
session_schema.go	`59.12% <100%> (ø)`	⬆️
session_insert.go	`56.84% <14.28%> (ø)`	⬆️
session_update.go	`56.44% <18.18%> (ø)`	⬆️
session.go	`57.9% <25%> (-0.59%)`	⬇️
session_raw.go	`57.57% <50%> (ø)`	⬆️
session_find.go	`67.91% <62.5%> (ø)`	⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce804ae...6e1a08b. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1283?src=pr&el=h1) Report > Merging [#1283](https://codecov.io/gh/go-xorm/xorm/pull/1283?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/ce804aee6c5118ed9a6bc04754aea4ea65232fe5?src=pr&el=desc) will **decrease** coverage by `0.06%`. > The diff coverage is `36.76%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/1283/graphs/tree.svg?width=650&token=yB5nO1krEe&height=150&src=pr)](https://codecov.io/gh/go-xorm/xorm/pull/1283?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1283 +/- ## ========================================== - Coverage 57.36% 57.29% -0.07% ========================================== Files 44 44 Lines 7817 7824 +7 ========================================== - Hits 4484 4483 -1 - Misses 2777 2783 +6 - Partials 556 558 +2 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/1283?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [session\_convert.go](https://codecov.io/gh/go-xorm/xorm/pull/1283/diff?src=pr&el=tree#diff-c2Vzc2lvbl9jb252ZXJ0Lmdv) | `22.29% <0%> (ø)` | :arrow_up: | | [session\_get.go](https://codecov.io/gh/go-xorm/xorm/pull/1283/diff?src=pr&el=tree#diff-c2Vzc2lvbl9nZXQuZ28=) | `75.83% <100%> (ø)` | :arrow_up: | | [session\_context.go](https://codecov.io/gh/go-xorm/xorm/pull/1283/diff?src=pr&el=tree#diff-c2Vzc2lvbl9jb250ZXh0Lmdv) | `75% <100%> (ø)` | :arrow_up: | | [session\_delete.go](https://codecov.io/gh/go-xorm/xorm/pull/1283/diff?src=pr&el=tree#diff-c2Vzc2lvbl9kZWxldGUuZ28=) | `58.22% <100%> (ø)` | :arrow_up: | | [session\_schema.go](https://codecov.io/gh/go-xorm/xorm/pull/1283/diff?src=pr&el=tree#diff-c2Vzc2lvbl9zY2hlbWEuZ28=) | `59.12% <100%> (ø)` | :arrow_up: | | [session\_insert.go](https://codecov.io/gh/go-xorm/xorm/pull/1283/diff?src=pr&el=tree#diff-c2Vzc2lvbl9pbnNlcnQuZ28=) | `56.84% <14.28%> (ø)` | :arrow_up: | | [session\_update.go](https://codecov.io/gh/go-xorm/xorm/pull/1283/diff?src=pr&el=tree#diff-c2Vzc2lvbl91cGRhdGUuZ28=) | `56.44% <18.18%> (ø)` | :arrow_up: | | [session.go](https://codecov.io/gh/go-xorm/xorm/pull/1283/diff?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `57.9% <25%> (-0.59%)` | :arrow_down: | | [session\_raw.go](https://codecov.io/gh/go-xorm/xorm/pull/1283/diff?src=pr&el=tree#diff-c2Vzc2lvbl9yYXcuZ28=) | `57.57% <50%> (ø)` | :arrow_up: | | [session\_find.go](https://codecov.io/gh/go-xorm/xorm/pull/1283/diff?src=pr&el=tree#diff-c2Vzc2lvbl9maW5kLmdv) | `67.91% <62.5%> (ø)` | :arrow_up: | | ... and [1 more](https://codecov.io/gh/go-xorm/xorm/pull/1283/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1283?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1283?src=pr&el=footer). Last update [ce804ae...6e1a08b](https://codecov.io/gh/go-xorm/xorm/pull/1283?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

betacat0 commented

2019-04-30 08:48:39 +00:00

Please add some tests for this change :)

lunny commented

2020-02-29 09:01:45 +00:00

Replaced by #1557

lunny closed this pull request

2020-02-29 09:02:35 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#1283