logger color #1349

lunny · 2019-07-05T08:59:03Z

wuxiaoxiaoshen commented

2019-07-05 08:59:03 +00:00

(Migrated from github.com)

logger with color
easy to use

- logger with color - easy to use

codecov-io commented

2019-07-05 09:04:45 +00:00

(Migrated from github.com)

Codecov Report

❗ No coverage uploaded for pull request base (master@9016f95). Click here to learn what that means.
The diff coverage is 0%.

@@           Coverage Diff            @@
##             master   #1349   +/-   ##
========================================
  Coverage          ?   57.3%           
========================================
  Files             ?      44           
  Lines             ?    7860           
  Branches          ?       0           
========================================
  Hits              ?    4504           
  Misses            ?    2800           
  Partials          ?     556

Impacted Files	Coverage Δ
logger.go	`43.75% <0%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9016f95...aff8ece. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1349?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@9016f95`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `0%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/1349/graphs/tree.svg?width=650&token=yB5nO1krEe&height=150&src=pr)](https://codecov.io/gh/go-xorm/xorm/pull/1349?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1349 +/- ## ======================================== Coverage ? 57.3% ======================================== Files ? 44 Lines ? 7860 Branches ? 0 ======================================== Hits ? 4504 Misses ? 2800 Partials ? 556 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/1349?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [logger.go](https://codecov.io/gh/go-xorm/xorm/pull/1349/diff?src=pr&el=tree#diff-bG9nZ2VyLmdv) | `43.75% <0%> (ø)` | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1349?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1349?src=pr&el=footer). Last update [9016f95...aff8ece](https://codecov.io/gh/go-xorm/xorm/pull/1349?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny commented

2019-07-05 13:37:29 +00:00

Hi, since core.ILogger is an interface, I think user could define himself logger package. You can find example in https://gitea.com/xorm/gitea_log_bridge which will be used by https://github.com/go-gitea/gitea when using xorm.

Hi, since `core.ILogger` is an interface, I think user could define himself logger package. You can find example in https://gitea.com/xorm/gitea_log_bridge which will be used by https://github.com/go-gitea/gitea when using xorm.

lunny commented

2019-07-30 07:08:55 +00:00

You can define yourself logger which implemented core.ILogger.

You can define yourself logger which implemented `core.ILogger`.

continuous-integration/drone/push Build is failing

Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#1349