Add insert select where support #1401

lunny · 2019-08-22T03:39:05Z

lunny commented

2019-08-22 03:39:05 +00:00

As title.

codecov-io commented

2019-08-22 03:56:10 +00:00

(Migrated from github.com)

Codecov Report

Merging #1401 into master will increase coverage by 0.08%.
The diff coverage is 52.85%.

@@            Coverage Diff             @@
##           master    #1401      +/-   ##
==========================================
+ Coverage   57.46%   57.54%   +0.08%     
==========================================
  Files          44       44              
  Lines        7915     7966      +51     
==========================================
+ Hits         4548     4584      +36     
- Misses       2804     2818      +14     
- Partials      563      564       +1

Impacted Files	Coverage Δ
session_insert.go	`58.68% <52.85%> (+1.72%)`	⬆️
xorm.go	`65.15% <0%> (-3.04%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b78ac8c...47b34ce. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1401?src=pr&el=h1) Report > Merging [#1401](https://codecov.io/gh/go-xorm/xorm/pull/1401?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/b78ac8ce0a8c507fb5045363ca9b0c4dcebb5723?src=pr&el=desc) will **increase** coverage by `0.08%`. > The diff coverage is `52.85%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/1401/graphs/tree.svg?width=650&token=yB5nO1krEe&height=150&src=pr)](https://codecov.io/gh/go-xorm/xorm/pull/1401?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1401 +/- ## ========================================== + Coverage 57.46% 57.54% +0.08% ========================================== Files 44 44 Lines 7915 7966 +51 ========================================== + Hits 4548 4584 +36 - Misses 2804 2818 +14 - Partials 563 564 +1 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/1401?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [session\_insert.go](https://codecov.io/gh/go-xorm/xorm/pull/1401/diff?src=pr&el=tree#diff-c2Vzc2lvbl9pbnNlcnQuZ28=) | `58.68% <52.85%> (+1.72%)` | :arrow_up: | | [xorm.go](https://codecov.io/gh/go-xorm/xorm/pull/1401/diff?src=pr&el=tree#diff-eG9ybS5nbw==) | `65.15% <0%> (-3.04%)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1401?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1401?src=pr&el=footer). Last update [b78ac8c...47b34ce](https://codecov.io/gh/go-xorm/xorm/pull/1401?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

guillep2k commented

2019-08-22 18:55:46 +00:00

(Migrated from github.com)

I'm a little late for this, but I've tested this with the Issue.Index feature in Gitea and it worked perfectly. I'll make a PR to add this over there.

By the way, this is the code generated for SQLITE:

2019/08/22 12:21:16 .../xorm/session_raw.go:178:exec() [I] [SQL] INSERT INTO `issue` (`repo_id`, `poster_id`, `original_author`, `original_author_id`, `name`, `content`, `milestone_id`, `priority`, `is_closed`, `is_pull`, `num_comments`, `ref`, `deadline_unix`, `created_unix`, `updated_unix`, `closed_unix`, `is_locked`, `index`) SELECT ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, coalesce(MAX(`index`),0)+1 FROM `issue` WHERE (repo_id=?) []interface {}{1, 1, "", 0, "This is a pull title", "", 0, 0, false, true, 0, "", 0, 1566487276, 1566487276, 0, false, 1} - took: 1.240578ms

I'm a little late for this, but I've tested this with the `Issue.Index` feature in Gitea and it worked perfectly. I'll make a PR to add this over there. By the way, this is the code generated for SQLITE: ``` 2019/08/22 12:21:16 .../xorm/session_raw.go:178:exec() [I] [SQL] INSERT INTO `issue` (`repo_id`, `poster_id`, `original_author`, `original_author_id`, `name`, `content`, `milestone_id`, `priority`, `is_closed`, `is_pull`, `num_comments`, `ref`, `deadline_unix`, `created_unix`, `updated_unix`, `closed_unix`, `is_locked`, `index`) SELECT ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, coalesce(MAX(`index`),0)+1 FROM `issue` WHERE (repo_id=?) []interface {}{1, 1, "", 0, "This is a pull title", "", 0, 0, false, true, 0, "", 0, 1566487276, 1566487276, 0, false, 1} - took: 1.240578ms ```

lunny referenced this issue from a commit

2019-10-21 03:51:46 +00:00

Add insert select where support (#1401)

lunny referenced this issue from a commit

2020-01-20 08:22:08 +00:00

lunny referenced this issue from a commit

2020-01-20 08:25:26 +00:00

Sign in to join this conversation.

No reviewers