Add quote policy support for table name and column name #1435

Closed
lunny wants to merge 11 commits from lunny/quote_policy into master
Owner
  • removed the syntax (id) support. This is a break change.
  • added SetTableQuotePolicy and SetColumnQuotePolicy on EngineInterface, this is also a break change for who implemented himself one.

Fix #1434

- [x] removed the syntax `(id)` support. This is a break change. - [x] added `SetTableQuotePolicy` and `SetColumnQuotePolicy` on `EngineInterface`, this is also a break change for who implemented himself one. Fix #1434
codecov-io commented 2019-09-25 14:22:36 +00:00 (Migrated from github.com)
Author
Owner

Codecov Report

Merging #1435 into master will increase coverage by 0.27%.
The diff coverage is 68.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1435      +/-   ##
==========================================
+ Coverage   56.88%   57.15%   +0.27%     
==========================================
  Files          48       49       +1     
  Lines        8190     8228      +38     
==========================================
+ Hits         4659     4703      +44     
+ Misses       2915     2908       -7     
- Partials      616      617       +1
Impacted Files Coverage Δ
helpers.go 58.98% <ø> (-0.75%) ⬇️
session_query.go 61.7% <0%> (ø) ⬆️
dialect_oracle.go 0% <0%> (ø) ⬆️
dialect_mssql.go 76.67% <100%> (+1.18%) ⬆️
dialect_sqlite3.go 80.7% <100%> (+1.31%) ⬆️
session_schema.go 57.72% <100%> (ø) ⬆️
engine_cond.go 56.29% <100%> (ø) ⬆️
session.go 58.49% <100%> (ø) ⬆️
xorm.go 70.58% <100%> (+2.4%) ⬆️
session_delete.go 58.22% <100%> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db25dfc...64dfdcb. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1435?src=pr&el=h1) Report > Merging [#1435](https://codecov.io/gh/go-xorm/xorm/pull/1435?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/db25dfc84e31f97b58127c4116b65fde8e7dbe02?src=pr&el=desc) will **increase** coverage by `0.27%`. > The diff coverage is `68.06%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/1435/graphs/tree.svg?width=650&token=yB5nO1krEe&height=150&src=pr)](https://codecov.io/gh/go-xorm/xorm/pull/1435?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1435 +/- ## ========================================== + Coverage 56.88% 57.15% +0.27% ========================================== Files 48 49 +1 Lines 8190 8228 +38 ========================================== + Hits 4659 4703 +44 + Misses 2915 2908 -7 - Partials 616 617 +1 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/1435?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [helpers.go](https://codecov.io/gh/go-xorm/xorm/pull/1435/diff?src=pr&el=tree#diff-aGVscGVycy5nbw==) | `58.98% <ø> (-0.75%)` | :arrow_down: | | [session\_query.go](https://codecov.io/gh/go-xorm/xorm/pull/1435/diff?src=pr&el=tree#diff-c2Vzc2lvbl9xdWVyeS5nbw==) | `61.7% <0%> (ø)` | :arrow_up: | | [dialect\_oracle.go](https://codecov.io/gh/go-xorm/xorm/pull/1435/diff?src=pr&el=tree#diff-ZGlhbGVjdF9vcmFjbGUuZ28=) | `0% <0%> (ø)` | :arrow_up: | | [dialect\_mssql.go](https://codecov.io/gh/go-xorm/xorm/pull/1435/diff?src=pr&el=tree#diff-ZGlhbGVjdF9tc3NxbC5nbw==) | `76.67% <100%> (+1.18%)` | :arrow_up: | | [dialect\_sqlite3.go](https://codecov.io/gh/go-xorm/xorm/pull/1435/diff?src=pr&el=tree#diff-ZGlhbGVjdF9zcWxpdGUzLmdv) | `80.7% <100%> (+1.31%)` | :arrow_up: | | [session\_schema.go](https://codecov.io/gh/go-xorm/xorm/pull/1435/diff?src=pr&el=tree#diff-c2Vzc2lvbl9zY2hlbWEuZ28=) | `57.72% <100%> (ø)` | :arrow_up: | | [engine\_cond.go](https://codecov.io/gh/go-xorm/xorm/pull/1435/diff?src=pr&el=tree#diff-ZW5naW5lX2NvbmQuZ28=) | `56.29% <100%> (ø)` | :arrow_up: | | [session.go](https://codecov.io/gh/go-xorm/xorm/pull/1435/diff?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `58.49% <100%> (ø)` | :arrow_up: | | [xorm.go](https://codecov.io/gh/go-xorm/xorm/pull/1435/diff?src=pr&el=tree#diff-eG9ybS5nbw==) | `70.58% <100%> (+2.4%)` | :arrow_up: | | [session\_delete.go](https://codecov.io/gh/go-xorm/xorm/pull/1435/diff?src=pr&el=tree#diff-c2Vzc2lvbl9kZWxldGUuZ28=) | `58.22% <100%> (ø)` | :arrow_up: | | ... and [13 more](https://codecov.io/gh/go-xorm/xorm/pull/1435/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1435?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1435?src=pr&el=footer). Last update [db25dfc...64dfdcb](https://codecov.io/gh/go-xorm/xorm/pull/1435?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
lunny added this to the 0.8.2 milestone 2019-10-23 08:36:30 +00:00
lunny modified the milestone from 0.8.2 to 1.1.1 2020-01-20 05:26:42 +00:00
lunny modified the milestone from 1.1.1 to 1.0.0 2020-02-24 06:34:24 +00:00
lunny removed this from the 1.0.0 milestone 2020-03-01 13:00:17 +00:00
lunny closed this pull request 2020-03-01 13:26:35 +00:00
Some checks reported errors
continuous-integration/drone/push Build is failing
continuous-integration/drone/pr Build was killed

Pull request closed

Sign in to join this conversation.
No description provided.