fix_batch_insert_interface_slice #1504

joelBai · 2020-01-06T02:46:38Z

joelBai commented

2020-01-06 02:46:38 +00:00

solution for xorm issue#1503

solution for [xorm issue#1503](https://gitea.com/xorm/xorm/issues/1503)

joelBai changed title from ~~WIP: fix_batch_insert_interface_slice~~ to fix_batch_insert_interface_slice

2020-01-06 02:59:04 +00:00

joelBai referenced this pull request

2020-01-06 03:23:57 +00:00

session.Insert(&[]interface{}) panic "reflect: call of reflect.Value.FieldByName on ptr Value" #1503

lunny reviewed 2020-01-06 05:12:13 +00:00

Dismissed

session_insert_test.go

						
				@ -567,0 +576,4 @@

						Userinfo{Username: "xlw22", Departname: "dev", Alias: "lunny3", Created: time.Now()},

					}

					cnt, err := testEngine.Insert(&users)

					if err != nil {

lunny commented

2020-01-06 05:12:13 +00:00

assert.NoError(t, err)

```assert.NoError(t, err)```

joelBai commented

2020-01-06 06:53:36 +00:00

done

lunny added the

kind

enhancement

label 2020-01-06 08:06:49 +00:00

lunny commented

2020-01-25 08:38:55 +00:00

CI failed.

lunny added this to the 1.1.1 milestone 2020-03-10 02:29:00 +00:00

lunny commented

2020-03-10 02:29:37 +00:00

Please resolve the conflicts.

joelBai commented

2020-03-12 07:06:50 +00:00

用于合并的分支修改基于两个月前的master,请问我现在需要移除项目重新fork,修改后重新提一个pr吗?

lunny commented

2020-03-12 08:15:17 +00:00

@joelBai You can rebase master or refork.

@joelBai You can `rebase master` or refork.

joelBai closed this pull request

2020-03-12 08:39:43 +00:00

lunny removed this from the 1.1.1 milestone 2020-03-23 12:50:00 +00:00

continuous-integration/drone/pr Build is failing

Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#1504