put ContextLogger in higher priority #1656
No reviewers
Labels
No Label
backport/done
backport/v1
blocked
db
oracle
db
sqlserver
duplicate
feature
cache
frontport/done
frontport/main
invalid
kind
breaking
kind
bug
kind
build
kind
dependencies
kind
docs
kind
driver
kind
enhancement
kind
feature
kind
performance
kind
proposal
kind
question
kind
refactor
kind
testing
need
feedback
need
test
proposal:accepted
RaspBerry Pi
regression
skip-changelog
upstream
wip
wontfix
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: xorm/xorm#1656
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "koron/xorm:logger-priority"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
SetLogger
usesLogger
when give a interface which implements bothContextLogger
andLogger
.Because of Go's type
switch
uses priorcase
.This PR makes xorm use
ContextLogger
in that case always.tests failed.
failed test https://drone.gitea.com/xorm/xorm/1041/1/14
amended and force pushed to restart CI
test passed w/o changes. just amend & force push.