xorm/xorm
xorm/xorm
63
356
Fork 204
Code Issues 369 Pull Requests 16 Actions Releases 35 Activity

chore: improve snakeCasedName performance #1688

Merged
lunny merged 3 commits from performance into master 2020-05-22 02:54:50 +00:00
Conversation 4 Commits 3 Files Changed 2 +24 -7
lunny commented 2020-05-21 14:01:01 +00:00
Owner
Copy Link
No description provided.
lunny added 1 commit 2020-05-21 14:01:03 +00:00
chore: improve snakeCasedName performance
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
cc74a8854a
lunny reviewed 2020-05-21 14:03:29 +00:00
Dismissed
names/mapper.go Outdated
@ -95,0 +98,4 @@
}
func snakeCasedNameNew(name string) string {
newstr := make([]byte, 0)
lunny commented 2020-05-21 14:03:29 +00:00
Author
Owner
Copy Link

How about give a length ? make([]byte, 0, len(name))

How about give a length ? `make([]byte, 0, len(name)) `
appleboy commented 2020-05-21 14:16:54 +00:00
Member
Copy Link

Done.

goos: darwin
goarch: amd64
pkg: xorm.io/xorm/names
BenchmarkSnakeCasedName-8         313640              3524 ns/op            2328 B/op          9 allocs/op
BenchmarkSnakeCasedNameNew-8     1901515               617 ns/op             576 B/op          2 allocs/op
PASS
ok      xorm.io/xorm/names      2.976s
Done. ``` goos: darwin goarch: amd64 pkg: xorm.io/xorm/names BenchmarkSnakeCasedName-8 313640 3524 ns/op 2328 B/op 9 allocs/op BenchmarkSnakeCasedNameNew-8 1901515 617 ns/op 576 B/op 2 allocs/op PASS ok xorm.io/xorm/names 2.976s ```
lunny commented 2020-05-21 14:25:41 +00:00
Author
Owner
Copy Link

Sorry, maybe newstr := make([]byte, 0, len(name)+1 is better.

Sorry, maybe `newstr := make([]byte, 0, len(name)+1` is better.
appleboy commented 2020-05-21 14:30:03 +00:00
Member
Copy Link

Done

Done
lunny added the
kind
performance
kind
enhancement
 labels 2020-05-21 14:04:38 +00:00
appleboy commented 2020-05-21 14:08:16 +00:00
Member
Copy Link

The following is bechmark result:

goos: darwin
goarch: amd64
pkg: xorm.io/xorm/names
BenchmarkSnakeCasedName-8         321931              3345 ns/op            2328 B/op          9 allocs/op
BenchmarkSnakeCasedNameNew-8     1577725               735 ns/op             504 B/op          6 allocs/op
PASS
ok      xorm.io/xorm/names      3.062s
The following is bechmark result: ``` goos: darwin goarch: amd64 pkg: xorm.io/xorm/names BenchmarkSnakeCasedName-8 321931 3345 ns/op 2328 B/op 9 allocs/op BenchmarkSnakeCasedNameNew-8 1577725 735 ns/op 504 B/op 6 allocs/op PASS ok xorm.io/xorm/names 3.062s ```
❤️ 1
appleboy commented 2020-05-21 14:11:05 +00:00
Member
Copy Link

@lunny I will remove the old source code befor merge the PR if review done.

@lunny I will remove the old source code befor merge the PR if review done.
👍 1
appleboy added 1 commit 2020-05-21 14:16:11 +00:00
chore: udpate
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
fdb6765648
appleboy added 1 commit 2020-05-21 14:30:00 +00:00
chore: update
All checks were successful
continuous-integration/drone/pr Build is passing
Details
continuous-integration/drone/push Build is passing
Details
99f0e5e05c
appleboy approved these changes 2020-05-21 14:30:43 +00:00
Dismissed
lunny added this to the 1.1.1 milestone 2020-05-21 14:31:33 +00:00
appleboy commented 2020-05-22 00:45:56 +00:00
Member
Copy Link

@lunny Please help to merge the PR.

@lunny Please help to merge the PR.
appleboy commented 2020-05-22 00:51:28 +00:00
Member
Copy Link

@lunny Please close the PR. We should cretae new PR and add you as reviewer.

@lunny Please close the PR. We should cretae new PR and add you as reviewer.
Screen Shot 2020-05-22 at 9.12.12 AM.png
17 KiB
Screen Shot 2020-05-22 at 9.12.12 AM.png
lunny merged commit d485101331 into master 2020-05-22 02:53:58 +00:00
lunny deleted branch performance 2020-05-22 02:54:56 +00:00
lunny modified the milestone from 1.1.1 to 1.0.2 2020-06-13 03:15:03 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backport/done

   
backport/v1

   
blocked
  
db
oracle

  
db
sqlserver

  
duplicate
  
feature
cache

  
frontport/done

   
frontport/main

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependencies

  
kind
docs

  
kind
driver

  
kind
enhancement

  
kind
feature

  
kind
performance

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
testing

  
need
feedback

  
need
test

  
proposal:accepted

   
RaspBerry Pi

   
regression

   
skip-changelog

   
upstream

   
wip

   
wontfix
No Label
backport/done
backport/v1
blocked
db
oracle
db
sqlserver
duplicate
feature
cache
frontport/done
frontport/main
invalid
kind
breaking
kind
bug
kind
build
kind
dependencies
kind
docs
kind
driver
kind
enhancement
kind
feature
kind
performance
kind
proposal
kind
question
kind
refactor
kind
testing
need
feedback
need
test
proposal:accepted
RaspBerry Pi
regression
skip-changelog
upstream
wip
wontfix
Milestone
Clear milestone
No items
No Milestone
1.0.2
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#1688
No description provided.
Delete Branch "performance"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?