xorm/xorm
xorm/xorm
63
356
Fork 205
Code Issues 371 Pull Requests 17 Actions Releases 35 Activity

add SetConnMaxIdleTime for go1.15 or higher #1774

Closed
Warashi wants to merge 3 commits from feature/add-setconnmaxidletime into master
pull from: feature/add-setconnmaxidletime
merge into: xorm:master
Conversation 3 Commits 3 Files Changed 5 +185 -68
Warashi commented 2020-08-25 21:55:03 +00:00
First-time contributor
Copy Link

sql.DB got SetConnMaxIdleTime at the go 1.15 release.

https://golang.org/doc/go1.15#database/sql
https://golang.org/pkg/database/sql/#DB.SetConnMaxIdleTime

This PR add SetConnMaxIdleTime method when using go 1.15 or higher.

sql.DB got SetConnMaxIdleTime at the go 1.15 release. https://golang.org/doc/go1.15#database/sql https://golang.org/pkg/database/sql/#DB.SetConnMaxIdleTime This PR add SetConnMaxIdleTime method when using go 1.15 or higher.
Warashi added 1 commit 2020-08-25 21:55:07 +00:00
add SetConnMaxIdleTime for go1.15 or higher
Some checks failed
continuous-integration/drone/pr Build is failing
Details
164d992622
Warashi commented 2020-08-25 22:14:18 +00:00
Author
First-time contributor
Copy Link

Test failed but this error maybe not occurred by this change.

--- FAIL: TestExistStructForJoin (0.32s)
    testing.go:809: race detected during execution of test
Test failed but this error maybe not occurred by this change. ``` --- FAIL: TestExistStructForJoin (0.32s) testing.go:809: race detected during execution of test ```
lunny added this to the 1.1.1 milestone 2021-04-10 05:21:25 +00:00
lunny modified the milestone from 1.1.1 to (deleted) 2021-06-07 05:52:47 +00:00
Darrenzzy commented 2023-01-06 03:17:55 +00:00
First-time contributor
Copy Link

这个什么时候可以支持 xorm 已经1.3.2了，对于sql的SetConnMaxIdleTime 设置还不能设置。

这个什么时候可以支持 xorm 已经1.3.2了，对于sql的SetConnMaxIdleTime 设置还不能设置。
lunny added 1 commit 2023-01-06 08:12:42 +00:00
fix bug
Some checks failed
continuous-integration/drone/pr Build is failing
Details
27d1248aa7
lunny added 1 commit 2023-01-06 15:13:42 +00:00
Fix interface
Some checks failed
continuous-integration/drone/pr Build is failing
Details
e5b6821e0e
lunny commented 2023-07-22 15:18:43 +00:00
Owner
Copy Link

This has been resolved.

This has been resolved.
lunny closed this pull request 2023-07-22 15:18:44 +00:00
lunny removed this from the (deleted) milestone 2023-07-26 01:22:33 +00:00
Some checks failed
continuous-integration/drone/pr Build is failing
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backport/done

   
backport/v1

   
blocked
  
db
oracle

  
db
sqlserver

  
duplicate
  
feature
cache

  
frontport/done

   
frontport/main

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependencies

  
kind
docs

  
kind
driver

  
kind
enhancement

  
kind
feature

  
kind
performance

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
testing

  
need
feedback

  
need
test

  
proposal:accepted

   
RaspBerry Pi

   
regression

   
skip-changelog

   
upstream

   
wip

   
wontfix
No Label
backport/done
backport/v1
blocked
db
oracle
db
sqlserver
duplicate
feature
cache
frontport/done
frontport/main
invalid
kind
breaking
kind
bug
kind
build
kind
dependencies
kind
docs
kind
driver
kind
enhancement
kind
feature
kind
performance
kind
proposal
kind
question
kind
refactor
kind
testing
need
feedback
need
test
proposal:accepted
RaspBerry Pi
regression
skip-changelog
upstream
wip
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#1774
No description provided.
Delete Branch "feature/add-setconnmaxidletime"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?