xorm/xorm
xorm/xorm
63
356
Fork 206
Code Issues 370 Pull Requests 19 Actions 9 Releases 35 Activity

Fix bug of ToDB when update on a nil pointer #1786

Merged
lunny merged 6 commits from lunny/fix_todb_upate into master 2020-09-08 15:40:29 +00:00
Conversation 1 Commits 6 Files Changed 3 +67 -14
lunny commented 2020-09-08 01:34:05 +00:00
Owner
Copy Link

Fix #1785

Fix #1785
lunny added this to the 1.0.5 milestone 2020-09-08 01:34:05 +00:00
lunny added the
kind
bug
 label 2020-09-08 01:34:05 +00:00
lunny force-pushed lunny/fix_todb_upate from 1915dcc94b to 4b9d2d6974 2020-09-08 01:48:59 +00:00 Compare
lunny added 1 commit 2020-09-08 04:56:53 +00:00
Fix test
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
981b83bb67
lunny added 1 commit 2020-09-08 08:32:54 +00:00
Add test for insert nil struct field
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
c2e9d7a21f
lunny added 1 commit 2020-09-08 09:30:34 +00:00
Fix bug
Some checks failed
continuous-integration/drone/pr Build is failing
Details
continuous-integration/drone/push Build is failing
Details
5434d62aa2
RelicOfTesla commented 2020-09-08 09:54:09 +00:00
First-time contributor
Copy Link
// /go/sdk_gopath/pkg/mod/xorm.io/xorm@v1.0.5-0.20200908093021-5434d62aa2d4/internal/statements/values.go:39 
// git 5434d62aa2d4b5076dc3d22399aae7fdd4dc27c3

if !fieldValue.IsNil() { // # call of reflect.Value.IsNil on int64 Value 
		if fieldConvert, ok := fieldValue.Interface().(convert.Conversion); ok {
```go // /go/sdk_gopath/pkg/mod/xorm.io/xorm@v1.0.5-0.20200908093021-5434d62aa2d4/internal/statements/values.go:39 // git 5434d62aa2d4b5076dc3d22399aae7fdd4dc27c3 if !fieldValue.IsNil() { // # call of reflect.Value.IsNil on int64 Value if fieldConvert, ok := fieldValue.Interface().(convert.Conversion); ok { ```
lunny added 1 commit 2020-09-08 11:38:25 +00:00
Fix bug
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is passing
Details
f761d3eefe
lunny added 1 commit 2020-09-08 12:28:10 +00:00
Fix test
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
96e5302ceb
lunny merged commit 1b200bdcba into master 2020-09-08 15:40:29 +00:00
lunny deleted branch lunny/fix_todb_upate 2020-09-08 15:40:48 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backport/done

   
backport/v1

   
blocked
  
db
oracle

  
db
sqlserver

  
duplicate
  
feature
cache

  
frontport/done

   
frontport/main

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependencies

  
kind
docs

  
kind
driver

  
kind
enhancement

  
kind
feature

  
kind
performance

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
testing

  
need
feedback

  
need
test

  
proposal:accepted

   
RaspBerry Pi

   
regression

   
skip-changelog

   
upstream

   
wip

   
wontfix
No Label
backport/done
backport/v1
blocked
db
oracle
db
sqlserver
duplicate
feature
cache
frontport/done
frontport/main
invalid
kind
breaking
kind
bug
kind
build
kind
dependencies
kind
docs
kind
driver
kind
enhancement
kind
feature
kind
performance
kind
proposal
kind
question
kind
refactor
kind
testing
need
feedback
need
test
proposal:accepted
RaspBerry Pi
regression
skip-changelog
upstream
wip
wontfix
Milestone
Clear milestone
No items
No Milestone
1.0.5
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#1786
No description provided.
Delete Branch "lunny/fix_todb_upate"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?