prevent panic when struct with unexport field #1839

Merged
lunny merged 4 commits from :fix_panic_with_unexport_fields into master 1 year ago
finelog commented 1 year ago

when using vanila protobuf generated struct (eg, without xorm struct tags) for xorm input, the unexported filed will cause panic, this pull request fix the panic, also making xorm functions ignoring unexport field without xorm tag though.
ps.thanks for your nice work.

when using vanila protobuf generated struct (eg, without xorm struct tags) for xorm input, the unexported filed will cause panic, this pull request fix the panic, also making xorm functions ignoring unexport field without xorm tag though. ps.thanks for your nice work.
finelog added 1 commit 1 year ago
a6b65d30c7 prevent panic when struct with unexport field
finelog started working 1 year ago
finelog cancelled time tracking 1 year ago

looks fine as in this case we don't need to use additional protoc plugin to tag unexported fields via xorm:"-"

looks fine as in this case we don't need to use additional protoc plugin to tag unexported fields via xorm:"-"
Owner

@finelog Could you add some test?

@finelog Could you add some test?
Poster

@finelog Could you add some test?

ok, I'll try

> @finelog Could you add some test? ok, I'll try
finelog added 1 commit 1 year ago
Poster

@finelog Could you add some test?

@lunny I have add test for my pr, please check it out. thanks!

> @finelog Could you add some test? @lunny I have add test for my pr, please check it out. thanks!
finelog added 1 commit 1 year ago
4538725949 minor code fix
finelog added 1 commit 1 year ago
55e7f68a77 minor fix part II
lunny approved these changes 1 year ago
Dismissed
lunny merged commit 3472d80a6d into master 1 year ago
Owner
@finelog @vtolstov Thanks!
lunny added this to the 1.0.6 milestone 1 year ago
lunny added the
kind/enhancement
label 1 year ago
Poster

it's pleasure. again, thanks for your work. really help us a lot.

it's pleasure. again, thanks for your work. really help us a lot.
continuous-integration/drone/pr Build encountered an error
The pull request has been merged as 3472d80a6d.
Sign in to join this conversation.
Loading…
There is no content yet.