xorm/xorm
xorm/xorm
64
359
Fork 208
Code Issues 373 Pull Requests 18 Actions Releases 35 Activity

RFC: Use provided type to create the dstTable rather than inferring from the SQL types #1872

Merged
lunny merged 18 commits from zeripath/xorm:dump-infer-from-type into master 2021-05-07 01:19:04 +00:00
Conversation 12 Commits 18 Files Changed 2 +3 -3
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 3ff3839b59 - Show all commits

6
engine.go
View File

@ -604,7 +604,7 @@ func (engine *Engine) dumpTables(tables []*schemas.Table, w io.Writer, tp ...sch
if table.Type != nil {
val := reflect.New(table.Type)
for rows.Next() {
err = rows.ScanStructByName(val)
err = rows.ScanStructByName(val.Interface())
if err != nil {
return err
}
@ -618,9 +618,9 @@ func (engine *Engine) dumpTables(tables []*schemas.Table, w io.Writer, tp ...sch
for _, d := range dstCols {
col := table.GetColumn(d)
if col == nil {
return errors.New("unknow column error")
return errors.New("unknown column error")
}
temp += "," + formatColumnValue(dstDialect, val.FieldByName(col.FieldName), col)
temp += "," + formatColumnValue(dstDialect, val.Elem().FieldByName(col.FieldName), col)
}
_, err = io.WriteString(w, temp[1:]+");\n")
if err != nil {