xorm/xorm
xorm/xorm
64
359
Fork 208
Code Issues 373 Pull Requests 18 Actions Releases 35 Activity

RFC: Use provided type to create the dstTable rather than inferring from the SQL types #1872

Merged
lunny merged 18 commits from zeripath/xorm:dump-infer-from-type into master 2021-05-07 01:19:04 +00:00
Conversation 12 Commits 18 Files Changed 2 +3 -6
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit ed8e7e426a - Show all commits

9
engine.go
View File

@ -604,9 +604,8 @@ func (engine *Engine) dumpTables(tables []*schemas.Table, w io.Writer, tp ...sch
if table.Type != nil {
sess := engine.NewSession()
defer sess.Close()
bean := reflect.New(table.Type)
for rows.Next() {
bean := reflect.New(table.Type)
fields, err := rows.Columns()
if err != nil {
return err
@ -615,11 +614,9 @@ func (engine *Engine) dumpTables(tables []*schemas.Table, w io.Writer, tp ...sch
if err != nil {
return err
}
// close it before convert data
rows.Close()
dataStruct := utils.ReflectValue(bean)
_, err = sess.slice2Bean(scanResults, fields, bean, &dataStruct, table)
dataStruct := utils.ReflectValue(bean.Interface())
_, err = sess.slice2Bean(scanResults, fields, bean.Interface(), &dataStruct, table)
if err != nil {
return err
}