MariaDB 10.5 adds a suffix on old datatypes #1885

Merged
lunny merged 2 commits from zeripath/xorm:cope-with-mariadb-5.3-suffix into master 1 year ago
Collaborator

MariaDB when encountering an old datetime type will add a suffix of /* mariadb-5.3 */
on its schema information page. Xorm does not understand this and then its mappings
fail.

The simplest solution is just to remove any fixed suffix and that is what this PR does

  • a clever solution would look for and remove any comments or match them.

See https://mariadb.com/kb/en/time/ for more details about the comment.

Related: https://github.com/go-gitea/gitea/issues/15277

Signed-off-by: Andrew Thornton art27@cantab.net

MariaDB when encountering an old datetime type will add a suffix of /* mariadb-5.3 */ on its schema information page. Xorm does not understand this and then its mappings fail. The simplest solution is just to remove any fixed suffix and that is what this PR does - a clever solution would look for and remove any comments or match them. See https://mariadb.com/kb/en/time/ for more details about the comment. Related: https://github.com/go-gitea/gitea/issues/15277 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath added 1 commit 1 year ago
dcfaed6a11
MariaDB 10.5 adds a suffix on old datatypes
zeripath added 1 commit 1 year ago
8a03ed1a2f
... kick drone ...
lunny approved these changes 1 year ago
Dismissed
lunny added this to the 1.1.1 milestone 1 year ago
lunny merged commit 21881d8b84 into master 1 year ago
zeripath deleted branch cope-with-mariadb-5.3-suffix 1 year ago
lunny modified the milestone from 1.1.1 to 1.1.0 1 year ago
The pull request has been merged as 21881d8b84.
Sign in to join this conversation.
Loading…
There is no content yet.