MariaDB 10.5 adds a suffix on old datatypes #1885

Merged
lunny merged 2 commits from zeripath/xorm:cope-with-mariadb-5.3-suffix into master 2021-04-08 06:12:40 +00:00
Contributor

MariaDB when encountering an old datetime type will add a suffix of /* mariadb-5.3 */
on its schema information page. Xorm does not understand this and then its mappings
fail.

The simplest solution is just to remove any fixed suffix and that is what this PR does

  • a clever solution would look for and remove any comments or match them.

See https://mariadb.com/kb/en/time/ for more details about the comment.

Related: https://github.com/go-gitea/gitea/issues/15277

Signed-off-by: Andrew Thornton art27@cantab.net

MariaDB when encountering an old datetime type will add a suffix of /* mariadb-5.3 */ on its schema information page. Xorm does not understand this and then its mappings fail. The simplest solution is just to remove any fixed suffix and that is what this PR does - a clever solution would look for and remove any comments or match them. See https://mariadb.com/kb/en/time/ for more details about the comment. Related: https://github.com/go-gitea/gitea/issues/15277 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath added 1 commit 2021-04-07 17:24:33 +00:00
Some checks reported errors
continuous-integration/drone/pr Build was killed
dcfaed6a11
MariaDB 10.5 adds a suffix on old datatypes
MariaDB when encountering an old datetime type will add a suffix of /* mariadb-5.3 */
on its schema information page. Xorm does not understand this and then its mappings
fail.

The simplest solution is just to remove any fixed suffix and that is what this PR does
- a clever solution would look for and remove any comments or match them.

See https://mariadb.com/kb/en/time/ for more details about the comment.

Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath added 1 commit 2021-04-07 20:22:05 +00:00
8a03ed1a2f
... kick drone ...
Signed-off-by: Andrew Thornton <art27@cantab.net>
lunny approved these changes 2021-04-08 06:12:12 +00:00
Dismissed
lunny added this to the 1.1.1 milestone 2021-04-08 06:12:19 +00:00
lunny merged commit 21881d8b84 into master 2021-04-08 06:12:40 +00:00
zeripath deleted branch cope-with-mariadb-5.3-suffix 2021-04-08 10:19:52 +00:00
lunny modified the milestone from 1.1.1 to 1.1.0 2021-05-14 09:05:41 +00:00
Sign in to join this conversation.
No description provided.