Byte strings in postgres aren't 0x... #1906

zeripath · 2021-05-08T19:03:37Z

zeripath commented

2021-05-08 19:03:37 +00:00

Byte strings in postgres are actually E'\x...' not 0x...

This is part of the follow-up to #1872

Signed-off-by: Andrew Thornton art27@cantab.net

Byte strings in postgres are actually E'\x...' not 0x... This is part of the follow-up to #1872 Signed-off-by: Andrew Thornton <art27@cantab.net>

zeripath added 1 commit 2021-05-08 19:03:37 +00:00

Byte strings in postgres aren't 0x...

Byte strings in postgres are actually E'\x...' not 0x...

This is part of the follow-up to #1872

Signed-off-by: Andrew Thornton <art27@cantab.net>

2d626529e5

zeripath commented

2021-05-08 19:04:07 +00:00

This bug was present prior to #1872 but #1872 has revealed the issue.

zeripath added 1 commit 2021-05-08 20:05:41 +00:00

Merge branch 'master' into fix-bytea-representation-in-postgres

continuous-integration/drone/pr Build is passing

Details

a23bc6e5d9

zeripath added 1 commit 2021-05-08 20:39:06 +00:00

Unfortunately there is another bug with Maps

Signed-off-by: Andrew Thornton <art27@cantab.net>

continuous-integration/drone/pr Build is passing

Details

6bfa2972d4

zeripath commented

2021-05-08 20:39:48 +00:00

Just noted another format value problem reflect.Map needs to be converted to json too.

zeripath commented

2021-05-08 21:09:32 +00:00

And I really think that that is it!

lunny approved these changes 2021-05-09 07:09:56 +00:00

lunny merged commit d2f52eba64 into master

2021-05-09 07:10:00 +00:00

lunny referenced this issue from a commit

2021-05-09 07:10:00 +00:00

Byte strings in postgres aren't 0x... (#1906)

zeripath deleted branch fix-bytea-representation-in-postgres

2021-05-09 20:58:50 +00:00

zeripath commented

2021-05-09 20:59:50 +00:00

Thanks @lunny I think we might now be able to finally have gitea dump do cross-database dumps properly.

zeripath commented

2021-05-14 08:59:26 +00:00

~rIpPeR~ on discord has tried this PR on gitea 1.14.x and successfully converted their db from sqlite to postgres without issues.

👍 1

lunny added this to the 1.1.0 milestone 2021-05-14 09:10:18 +00:00

steled referenced this pull request from gitea/helm-chart

2021-08-29 08:26:55 +00:00

[version 1.14.6] - Pod restart fails after migration #215

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#1906