Byte strings in postgres aren't 0x... #1906

Merged
lunny merged 3 commits from zeripath/xorm:fix-bytea-representation-in-postgres into master 7 months ago

Byte strings in postgres are actually E'\x...' not 0x...

This is part of the follow-up to #1872

Signed-off-by: Andrew Thornton art27@cantab.net

Byte strings in postgres are actually E'\x...' not 0x... This is part of the follow-up to #1872 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath added 1 commit 7 months ago
2d626529e5
Byte strings in postgres aren't 0x...
Poster

This bug was present prior to #1872 but #1872 has revealed the issue.

This bug was present prior to #1872 but #1872 has revealed the issue.
zeripath added 1 commit 7 months ago
zeripath added 1 commit 7 months ago
6bfa2972d4
Unfortunately there is another bug with Maps
Poster

Just noted another format value problem reflect.Map needs to be converted to json too.

Just noted another format value problem reflect.Map needs to be converted to json too.
Poster

And I really think that that is it!

And I really think that that is it!
lunny approved these changes 7 months ago
lunny merged commit d2f52eba64 into master 7 months ago
zeripath deleted branch fix-bytea-representation-in-postgres 7 months ago
Poster

Thanks @lunny I think we might now be able to finally have gitea dump do cross-database dumps properly.

Thanks @lunny I think we might now be able to finally have gitea dump do cross-database dumps properly.
Poster

~rIpPeR~ on discord has tried this PR on gitea 1.14.x and successfully converted their db from sqlite to postgres without issues.

~rIpPeR~ on discord has tried this PR on gitea 1.14.x and successfully converted their db from sqlite to postgres without issues.
lunny added this to the 1.1.0 milestone 7 months ago

Reviewers

lunny approved these changes 7 months ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as d2f52eba64.
Sign in to join this conversation.
Loading…
There is no content yet.