xorm/xorm
xorm/xorm
63
356
Fork 206
Code Issues 372 Pull Requests 18 Actions Releases 35 Activity

Fix exist #1921

Merged
lunny merged 2 commits from lunny/fix_exist2 into master 2021-06-07 05:45:35 +00:00
Conversation 0 Commits 2 Files Changed 2 +6 -3
3 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 094bafd864 - Show all commits

2
dialects/dialect.go
View File

@ -217,7 +217,7 @@ func regDrvsNDialects() bool {
"sqlite3": {"sqlite3", func() Driver { return &sqlite3Driver{} }, func() Dialect { return &sqlite3{} }},
"sqlite": {"sqlite3", func() Driver { return &sqlite3Driver{} }, func() Dialect { return &sqlite3{} }},
"oci8": {"oracle", func() Driver { return &oci8Driver{} }, func() Dialect { return &oracle{} }},
"goracle": {"oracle", func() Driver { return &goracleDriver{} }, func() Dialect { return &oracle{} }},
"godror": {"oracle", func() Driver { return &godrorDriver{} }, func() Dialect { return &oracle{} }},
}
for driverName, v := range providedDrvsNDialects {

4
dialects/oracle.go
View File

@ -802,10 +802,10 @@ func (db *oracle) Filters() []Filter {
}
}
type goracleDriver struct {
type godrorDriver struct {
}
func (cfg *goracleDriver) Parse(driverName, dataSourceName string) (*URI, error) {
func (cfg *godrorDriver) Parse(driverName, dataSourceName string) (*URI, error) {
db := &URI{DBType: schemas.ORACLE}
dsnPattern := regexp.MustCompile(
`^(?:(?P<user>.*?)(?::(?P<passwd>.*))?@)?` + // [user[:password]@]

3
integrations/session_find_test.go
View File

@ -84,6 +84,9 @@ func TestFind(t *testing.T) {
err := testEngine.Find(&users)
assert.NoError(t, err)
err = testEngine.Limit(10, 0).Find(&users)
assert.NoError(t, err)
users2 := make([]Userinfo, 0)
var tbName = testEngine.Quote(testEngine.TableName(new(Userinfo), true))
err = testEngine.SQL("select * from " + tbName).Find(&users2)