Support delete with no bean #1926

Merged

lunny merged 4 commits from lunny/delete into master 2021-07-06 09:11:45 +00:00

Conversation 3 Commits 4 Files Changed 6 +87 -42

lunny commented 2021-06-08 08:53:22 +00:00

Owner

Copy Link

Now you can use delete like this:

orm.Table("my_table").Where("id=?",1).Delete()

Now you can use delete like this: ``` orm.Table("my_table").Where("id=?",1).Delete() ```

lunny added the

kind

enhancement

label 2021-06-08 08:53:22 +00:00

lunny force-pushed lunny/delete from 07444ffe27 to 286a929433 2021-06-08 08:53:54 +00:00 Compare

lunny added 1 commit 2021-06-08 09:10:01 +00:00

Update README 4552e26d7b

lunny added 1 commit 2021-06-08 09:34:28 +00:00

Fix build c4f8c17d71

lunny added 1 commit 2021-06-08 11:15:35 +00:00

Fix test 515a0ff4ce

lunny added this to the 1.2.0 milestone 2021-06-08 12:26:05 +00:00

lunny added the

kind

breaking

label 2021-06-08 12:26:12 +00:00

6543 commented 2021-06-08 12:50:08 +00:00

Contributor

Copy Link

since .Delete(&User{ID: 1}, &User{ID: 2}, ...) is now also valide, should it be checked or supported?

since `.Delete(&User{ID: 1}, &User{ID: 2}, ...)` is now also valide, should it be checked or supported?

lunny commented 2021-06-09 05:14:20 +00:00

Author

Owner

Copy Link

since .Delete(&User{ID: 1}, &User{ID: 2}, ...) is now also valide, should it be checked or supported?

Should we support deleted multiple object here?

> since `.Delete(&User{ID: 1}, &User{ID: 2}, ...)` is now also valide, should it be checked or supported? Should we support deleted multiple object here?

lunny commented 2021-07-06 09:11:33 +00:00

Author

Owner

Copy Link

since .Delete(&User{ID: 1}, &User{ID: 2}, ...) is now also valide, should it be checked or supported?

That could be another PR.

> since `.Delete(&User{ID: 1}, &User{ID: 2}, ...)` is now also valide, should it be checked or supported? That could be another PR.

😆 1

lunny merged commit 8f64a78cd4 into master 2021-07-06 09:11:45 +00:00

lunny referenced this issue from a commit 2021-07-06 09:11:45 +00:00

Support delete with no bean (#1926)

lunny deleted branch lunny/delete 2021-07-06 09:11:51 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backport/done

  

backport/v1

  

blocked

  

db

oracle

  

db

sqlserver

  

duplicate

  

feature

cache

  

frontport/done

  

frontport/main

  

invalid

  

kind

breaking

  

kind

bug

  

kind

build

  

kind

dependencies

  

kind

docs

  

kind

driver

  

kind

enhancement

  

kind

feature

  

kind

performance

  

kind

proposal

  

kind

question

  

kind

refactor

  

kind

testing

  

need

feedback

  

need

test

  

proposal:accepted

  

RaspBerry Pi

  

regression

  

skip-changelog

  

upstream

  

wip

  

wontfix

No Label

backport/done

backport/v1

blocked

db

oracle

db

sqlserver

duplicate

feature

cache

frontport/done

frontport/main

invalid

kind

breaking

kind

bug

kind

build

kind

dependencies

kind

docs

kind

driver

kind

enhancement

kind

feature

kind

performance

kind

proposal

kind

question

kind

refactor

kind

testing

need

feedback

need

test

proposal:accepted

RaspBerry Pi

regression

skip-changelog

upstream

wip

wontfix

Milestone

Clear milestone

No items

No Milestone

1.2.0

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#1926

No description provided.