xorm/xorm
xorm/xorm
63
355
Fork 204
Code Issues 369 Pull Requests 15 Actions Releases 35 Activity

Fix issue with byte representation in MSSQL #1957

Merged
lunny merged 2 commits from zeripath/xorm:fix-missing-string-if-not-blob into master 2021-07-23 01:01:50 +00:00
Conversation 6 Commits 2 Files Changed 1 +6
zeripath commented 2021-06-26 19:43:51 +00:00
Contributor
Copy Link

There is a missing cast to string in BuildUpdates which leads to a failure
to call str2ucs and ucs2str for converts on MSSQL.

Ref: https://github.com/go-gitea/gitea/issues/16252

Signed-off-by: Andrew Thornton art27@cantab.net

There is a missing cast to string in BuildUpdates which leads to a failure to call str2ucs and ucs2str for converts on MSSQL. Ref: https://github.com/go-gitea/gitea/issues/16252 Signed-off-by: Andrew Thornton <art27@cantab.net>
👍 1
lunny commented 2021-06-27 03:14:44 +00:00
Owner
Copy Link

@zeripath Could you add a test with this?

@zeripath Could you add a test with this?
lunny commented 2021-07-14 03:27:04 +00:00
Owner
Copy Link

Please resolve the conflict.

Please resolve the conflict.
zeripath force-pushed fix-missing-string-if-not-blob from a5c4676eb2 to 76d91bc218 2021-07-20 20:20:17 +00:00 Compare
zeripath commented 2021-07-20 20:22:15 +00:00
Author
Contributor
Copy Link

So in terms of the test I don't understand why it isn't already failing in TestConversion.

Have you been able to figure out a testcase?

So in terms of the test I don't understand why it isn't already failing in TestConversion. Have you been able to figure out a testcase?
zeripath added 1 commit 2021-07-22 12:02:02 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
Details
d5142257f1 Merge branch 'master' into fix-missing-string-if-not-blob
lunny commented 2021-07-22 15:22:44 +00:00
Owner
Copy Link

So in terms of the test I don't understand why it isn't already failing in TestConversion.

Have you been able to figure out a testcase?

It seems both bytes and string will pass the tests.

> So in terms of the test I don't understand why it isn't already failing in TestConversion. > > Have you been able to figure out a testcase? It seems both bytes and string will pass the tests.
zeripath commented 2021-07-22 21:41:49 +00:00
Author
Contributor
Copy Link

But the problem is very much real on Gitea so I'm uncertain as to why it's so easy to reproduce there but not here.

But the problem is very much real on Gitea so I'm uncertain as to why it's so easy to reproduce there but not here.
lunny commented 2021-07-23 01:01:45 +00:00
Owner
Copy Link

If it can resolve gitea's problem and CI PASS. Let's merge it.

If it can resolve gitea's problem and CI PASS. Let's merge it.
lunny merged commit d973423802 into master 2021-07-23 01:01:50 +00:00
zeripath deleted branch fix-missing-string-if-not-blob 2021-07-23 07:42:45 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backport/done

   
backport/v1

   
blocked
  
db
oracle

  
db
sqlserver

  
duplicate
  
feature
cache

  
frontport/done

   
frontport/main

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependencies

  
kind
docs

  
kind
driver

  
kind
enhancement

  
kind
feature

  
kind
performance

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
testing

  
need
feedback

  
need
test

  
proposal:accepted

   
RaspBerry Pi

   
regression

   
skip-changelog

   
upstream

   
wip

   
wontfix
No Label
backport/done
backport/v1
blocked
db
oracle
db
sqlserver
duplicate
feature
cache
frontport/done
frontport/main
invalid
kind
breaking
kind
bug
kind
build
kind
dependencies
kind
docs
kind
driver
kind
enhancement
kind
feature
kind
performance
kind
proposal
kind
question
kind
refactor
kind
testing
need
feedback
need
test
proposal:accepted
RaspBerry Pi
regression
skip-changelog
upstream
wip
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#1957
No description provided.
Delete Branch "zeripath/xorm:fix-missing-string-if-not-blob"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?