Fix issue with byte representation in MSSQL #1957

Merged
lunny merged 2 commits from zeripath/xorm:fix-missing-string-if-not-blob into master 2 months ago

There is a missing cast to string in BuildUpdates which leads to a failure
to call str2ucs and ucs2str for converts on MSSQL.

Ref: https://github.com/go-gitea/gitea/issues/16252

Signed-off-by: Andrew Thornton art27@cantab.net

There is a missing cast to string in BuildUpdates which leads to a failure to call str2ucs and ucs2str for converts on MSSQL. Ref: https://github.com/go-gitea/gitea/issues/16252 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath added 1 commit 3 months ago
a5c4676eb2
Fix issue with byte representation in MSSQL
Owner

@zeripath Could you add a test with this?

@zeripath Could you add a test with this?
Owner

Please resolve the conflict.

Please resolve the conflict.
zeripath force-pushed fix-missing-string-if-not-blob from a5c4676eb2 to 76d91bc218 2 months ago
Poster

So in terms of the test I don't understand why it isn't already failing in TestConversion.

Have you been able to figure out a testcase?

So in terms of the test I don't understand why it isn't already failing in TestConversion. Have you been able to figure out a testcase?
zeripath added 1 commit 2 months ago
Owner

So in terms of the test I don't understand why it isn't already failing in TestConversion.

Have you been able to figure out a testcase?

It seems both bytes and string will pass the tests.

> So in terms of the test I don't understand why it isn't already failing in TestConversion. > > Have you been able to figure out a testcase? It seems both bytes and string will pass the tests.
Poster

But the problem is very much real on Gitea so I'm uncertain as to why it's so easy to reproduce there but not here.

But the problem is very much real on Gitea so I'm uncertain as to why it's so easy to reproduce there but not here.
Owner

If it can resolve gitea's problem and CI PASS. Let's merge it.

If it can resolve gitea's problem and CI PASS. Let's merge it.
lunny merged commit d973423802 into master 2 months ago
zeripath deleted branch fix-missing-string-if-not-blob 2 months ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as d973423802.
Sign in to join this conversation.
Loading…
There is no content yet.