xorm/xorm
xorm/xorm
63
356
Fork 206
Code Issues 371 Pull Requests 18 Actions Releases 35 Activity

fix postgres datatype NUMERIC scan #1969

Closed
i4colorfixer wants to merge 1 commits from master into master
pull from: master
merge into: xorm:master
Conversation 6 Commits 1 Files Changed 1 +1 -1
i4colorfixer commented 2021-07-06 09:18:37 +00:00
First-time contributor
Copy Link
No description provided.
i4colorfixer added 1 commit 2021-07-06 09:18:38 +00:00
fix postgres datatype NUMERIC scan
All checks were successful
continuous-integration/drone/pr Build is passing
Details
6d45bb8d6c
lunny commented 2021-07-10 15:45:44 +00:00
Owner
Copy Link

Which type should we use for numeric? float64, string or big.Float?

Which type should we use for numeric? `float64`, `string` or `big.Float`?
4color commented 2021-07-10 16:30:38 +00:00
Contributor
Copy Link

Which type should we use for numeric? float64, string or big.Float?

i guess float64

> Which type should we use for numeric? `float64`, `string` or `big.Float`? i guess float64
lunny commented 2021-07-11 02:30:03 +00:00
Owner
Copy Link

Which type should we use for numeric? float64, string or big.Float?

i guess float64

But that may lose some precision. Maybe string is better or big.Float.

> > Which type should we use for numeric? `float64`, `string` or `big.Float`? > > i guess float64 But that may lose some precision. Maybe `string` is better or `big.Float`.
4color commented 2021-07-12 02:05:23 +00:00
Contributor
Copy Link

Which type should we use for numeric? float64, string or big.Float?

i guess float64

But that may lose some precision. Maybe string is better or big.Float.

我没有精确的测试过。string肯定不行,类型都不对了。那估计就是用big.Float

> > > Which type should we use for numeric? `float64`, `string` or `big.Float`? > > > > i guess float64 > > But that may lose some precision. Maybe `string` is better or `big.Float`. 我没有精确的测试过。string肯定不行,类型都不对了。那估计就是用big.Float
lunny commented 2021-09-15 07:02:57 +00:00
Owner
Copy Link

I think string is a better one.

I think string is a better one.
lunny commented 2023-07-22 15:37:00 +00:00
Owner
Copy Link

outdated

outdated
lunny closed this pull request 2023-07-22 15:37:00 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backport/done

   
backport/v1

   
blocked
  
db
oracle

  
db
sqlserver

  
duplicate
  
feature
cache

  
frontport/done

   
frontport/main

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependencies

  
kind
docs

  
kind
driver

  
kind
enhancement

  
kind
feature

  
kind
performance

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
testing

  
need
feedback

  
need
test

  
proposal:accepted

   
RaspBerry Pi

   
regression

   
skip-changelog

   
upstream

   
wip

   
wontfix
No Label
backport/done
backport/v1
blocked
db
oracle
db
sqlserver
duplicate
feature
cache
frontport/done
frontport/main
invalid
kind
breaking
kind
bug
kind
build
kind
dependencies
kind
docs
kind
driver
kind
enhancement
kind
feature
kind
performance
kind
proposal
kind
question
kind
refactor
kind
testing
need
feedback
need
test
proposal:accepted
RaspBerry Pi
regression
skip-changelog
upstream
wip
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#1969
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?