xorm/xorm
xorm/xorm
63
355
Fork 204
Code Issues 368 Pull Requests 16 Actions Releases 35 Activity

fix panic when convert sql and args with nil time.Time pointer #2038

Merged
lunny merged 1 commits from finelog/xorm:fix_sql_args_panic into master 2021-08-25 16:03:19 +00:00
Conversation 0 Commits 1 Files Changed 2 +19 -2
finelog commented 2021-08-25 14:07:52 +00:00
Contributor
Copy Link

this pr fix a panic, when using nil time.Time pointer for input.
not sure if there are others similar code.
please review it, thanks!

this pr fix a panic, when using nil time.Time pointer for input. not sure if there are others similar code. please review it, thanks!
finelog added 1 commit 2021-08-25 14:07:52 +00:00
fix panic when convert sql and args with nil time.Time pointer
All checks were successful
continuous-integration/drone/pr Build is passing
Details
d3bce4b8d7
lunny approved these changes 2021-08-25 16:03:14 +00:00
lunny merged commit e5c89cf55e into master 2021-08-25 16:03:19 +00:00
lunny added the
kind
bug
 label 2021-08-25 16:03:32 +00:00
lunny added this to the 1.3.0 milestone 2021-08-25 16:03:36 +00:00
finelog deleted branch fix_sql_args_panic 2021-08-25 16:48:21 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
lunny
Labels
Clear labels   
backport/done

   
backport/v1

   
blocked
  
db
oracle

  
db
sqlserver

  
duplicate
  
feature
cache

  
frontport/done

   
frontport/main

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependencies

  
kind
docs

  
kind
driver

  
kind
enhancement

  
kind
feature

  
kind
performance

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
testing

  
need
feedback

  
need
test

  
proposal:accepted

   
RaspBerry Pi

   
regression

   
skip-changelog

   
upstream

   
wip

   
wontfix
No Label
backport/done
backport/v1
blocked
db
oracle
db
sqlserver
duplicate
feature
cache
frontport/done
frontport/main
invalid
kind
breaking
kind
bug
kind
build
kind
dependencies
kind
docs
kind
driver
kind
enhancement
kind
feature
kind
performance
kind
proposal
kind
question
kind
refactor
kind
testing
need
feedback
need
test
proposal:accepted
RaspBerry Pi
regression
skip-changelog
upstream
wip
wontfix
Milestone
Clear milestone
No items
No Milestone
1.3.0
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#2038
No description provided.
Delete Branch "finelog/xorm:fix_sql_args_panic"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?