Fix to add session.statement.IsForUpdate check in Session.queryRows() #2064

Merged
lunny merged 4 commits from rennnosuke/xorm:fix/exec_for_update_on_master into master 5 days ago

Issue

The 'for-update' query is executed to slave DB node.

Example

s := engineGroup.NewSession(); // create session from EngineGroup.
...

s.ForUpdate();

type User struct { ... };
var user User;
has, err := s.Get(&user); // executed to slave DB node.
...
# Issue The 'for-update' query is executed to slave DB node. # Example ```go s := engineGroup.NewSession(); // create session from EngineGroup. ... s.ForUpdate(); type User struct { ... }; var user User; has, err := s.Get(&user); // executed to slave DB node. ... ```
rennnosuke added 1 commit 1 month ago
e03ecdfeee fix to add session.statement.IsForUpdate check in Session.queryRows()
lunny approved these changes 1 month ago
lunny added this to the 1.3.0 milestone 1 month ago
lunny added the
kind/enhancement
label 1 month ago
Owner

Please resolve the conflict.

Please resolve the conflict.
rennnosuke added 1 commit 1 month ago
lunny added 1 commit 1 month ago
Poster

@lunny
It seems that some CI steps are failing due to OOM. Could you retry to run those steps or confirm the CI configuration?

@lunny It seems that some CI steps are failing due to OOM. Could you retry to run those steps or confirm the CI configuration?
rennnosuke added 1 commit 5 days ago
lunny merged commit 885f582677 into master 5 days ago

Reviewers

lunny approved these changes 1 month ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as 885f582677.
Sign in to join this conversation.
Loading…
There is no content yet.