From e03ecdfeeeb3550d87fdb22cb999f68dbdfbca27 Mon Sep 17 00:00:00 2001 From: rennnosuke Date: Thu, 28 Oct 2021 16:38:22 +0800 Subject: [PATCH] fix to add session.statement.IsForUpdate check in Session.queryRows() # Issue The 'for-update' query is executed to slave DB node. # Example ```go s := engineGroup.NewSession(); // create session from EngineGroup. ... s.ForUpdate(); type User struct { ... }; has, err := s.Get(&user); // executed to slave DB node. ... ``` --- session_raw.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/session_raw.go b/session_raw.go index acb106a5..00177374 100644 --- a/session_raw.go +++ b/session_raw.go @@ -33,7 +33,7 @@ func (session *Session) queryRows(sqlStr string, args ...interface{}) (*core.Row if session.isAutoCommit { var db *core.DB - if session.sessionType == groupSession && strings.EqualFold(sqlStr[:6], "select") { + if session.sessionType == groupSession && strings.EqualFold(sqlStr[:6], "select") && !session.statement.IsForUpdate { db = session.engine.engineGroup.Slave().DB() } else { db = session.DB() -- 2.40.1