xorm/xorm
xorm/xorm
63
355
Fork 204
Code Issues 369 Pull Requests 15 Actions Releases 35 Activity

MySQL/MariaDB: return max length for text columns #2133

Merged
lunny merged 4 commits from pilou/xorm:mysql_return_column_max_len into master 2022-04-22 02:48:54 +00:00
Conversation 2 Commits 4 Files Changed 3 +48 -4
pilou commented 2022-04-15 21:26:26 +00:00
Contributor
Copy Link

MySQL/MariaDB: return max length for text columns using CHARACTER_MAXIMUM_LENGTH.

Tests:

  • add an integration test: TestGetColumnsLength
  • update TestSyncTable3 since TableInfo isn't able to provide the column size
MySQL/MariaDB: return max length for text columns using `CHARACTER_MAXIMUM_LENGTH`. Tests: * add an integration test: `TestGetColumnsLength` * update `TestSyncTable3` since `TableInfo` isn't able to provide the column size
pilou force-pushed mysql_return_column_max_len from 04e6719532 to 7bbdfa76cd 2022-04-17 06:55:25 +00:00 Compare
pilou force-pushed mysql_return_column_max_len from 7bbdfa76cd to 1710100b5c 2022-04-17 07:20:40 +00:00 Compare
pilou commented 2022-04-17 07:23:42 +00:00
Author
Contributor
Copy Link

Updated:

  • rebased on master
  • test TestSyncTable3 updated
Updated: * rebased on master * test TestSyncTable3 updated
lunny added this to the 1.3.1 milestone 2022-04-17 10:04:53 +00:00
lunny added the
kind
enhancement
 label 2022-04-17 10:05:04 +00:00
pilou force-pushed mysql_return_column_max_len from bcf55c0db0 to 55377b94b1 2022-04-21 07:16:07 +00:00 Compare
pilou commented 2022-04-21 07:17:33 +00:00
Author
Contributor
Copy Link

Updated:

  • rebased (on master)
  • make fmt applied
Updated: - rebased (on master) - `make fmt` applied
lunny added 1 commit 2022-04-22 02:20:43 +00:00
Merge branch 'master' into mysql_return_column_max_len
All checks were successful
continuous-integration/drone/pr Build is passing
Details
b8f08e1607
lunny approved these changes 2022-04-22 02:48:37 +00:00
lunny merged commit e1d4365667 into master 2022-04-22 02:48:54 +00:00
pilou deleted branch mysql_return_column_max_len 2022-04-22 02:50:26 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
lunny
Labels
Clear labels   
backport/done

   
backport/v1

   
blocked
  
db
oracle

  
db
sqlserver

  
duplicate
  
feature
cache

  
frontport/done

   
frontport/main

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependencies

  
kind
docs

  
kind
driver

  
kind
enhancement

  
kind
feature

  
kind
performance

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
testing

  
need
feedback

  
need
test

  
proposal:accepted

   
RaspBerry Pi

   
regression

   
skip-changelog

   
upstream

   
wip

   
wontfix
No Label
backport/done
backport/v1
blocked
db
oracle
db
sqlserver
duplicate
feature
cache
frontport/done
frontport/main
invalid
kind
breaking
kind
bug
kind
build
kind
dependencies
kind
docs
kind
driver
kind
enhancement
kind
feature
kind
performance
kind
proposal
kind
question
kind
refactor
kind
testing
need
feedback
need
test
proposal:accepted
RaspBerry Pi
regression
skip-changelog
upstream
wip
wontfix
Milestone
Clear milestone
No items
No Milestone
1.3.1
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#2133
No description provided.
Delete Branch "pilou/xorm:mysql_return_column_max_len"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?