Labels Milestones

MySQL/MariaDB: return max length for text columns #2133

Merged

lunny merged 4 commits from pilou/xorm:mysql_return_column_max_len into master 4 weeks ago

Conversation 2 Commits 4 Files Changed 3

pilou commented 1 month ago

MySQL/MariaDB: return max length for text columns using CHARACTER_MAXIMUM_LENGTH.

Tests:

• add an integration test: TestGetColumnsLength
• update TestSyncTable3 since TableInfo isn't able to provide the column size

MySQL/MariaDB: return max length for text columns using `CHARACTER_MAXIMUM_LENGTH`. Tests: * add an integration test: `TestGetColumnsLength` * update `TestSyncTable3` since `TableInfo` isn't able to provide the column size

pilou added 3 commits 1 month ago

33f23be5c5

tests: check max length is available for TEXT cols

d634a5a9dc

MySQL/MariaDB: return max length for text columns

continuous-integration/drone/pr Build is failing

Details

04e6719532

DBMetas is able to extract column size, TableInfo isn't ...

Engine.DBMetas() returns the size of the column from the database but
Engine.TableInfo() isn't able to guess the column size. For example
when utf-8 charset is used, "`xorm:"TEXT(21846)`" creates a MEDIUMTEXT
column not a TEXT column.

pilou force-pushed mysql_return_column_max_len from 04e6719532 to 7bbdfa76cd 1 month ago

pilou force-pushed mysql_return_column_max_len from 7bbdfa76cd to 1710100b5c 1 month ago

pilou commented 1 month ago

Poster

Updated:

• rebased on master
• test TestSyncTable3 updated

Updated: * rebased on master * test TestSyncTable3 updated

lunny added 1 commit 1 month ago

continuous-integration/drone/pr Build is failing

Details

bcf55c0db0 Merge branch 'master' into mysql_return_column_max_len

lunny added this to the 1.3.1 milestone 1 month ago

lunny added the

kind/enhancement

label 1 month ago

pilou force-pushed mysql_return_column_max_len from bcf55c0db0 to 55377b94b1 4 weeks ago

pilou commented 4 weeks ago

Poster

Updated:

• rebased (on master)
• make fmt applied

Updated: - rebased (on master) - `make fmt` applied

lunny added 1 commit 4 weeks ago

continuous-integration/drone/pr Build is passing

Details

b8f08e1607 Merge branch 'master' into mysql_return_column_max_len

lunny approved these changes 4 weeks ago

lunny merged commit e1d4365667 into master 4 weeks ago

lunny referenced this issue from a commit 4 weeks ago

MySQL/MariaDB: return max length for text columns (#2133)

pilou deleted branch mysql_return_column_max_len 4 weeks ago

Reviewers

lunny approved these changes 4 weeks ago

continuous-integration/drone/pr Build is passing

Details

The pull request has been merged as e1d4365667.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

lunny

Labels

Apply labels

Clear labels

blocked db/oracle db/sqlserver duplicate feature/cache invalid kind/breaking kind/bug kind/build kind/dependencies kind/docs kind/driver kind/enhancement kind/feature kind/performance kind/proposal kind/proposal:accepted kind/question kind/refactor kind/regression kind/testing kind/upstream need/feedback need/test RaspBerry Pi skip-changelog wip wontfix

No Label blocked db/oracle db/sqlserver duplicate feature/cache invalid kind/breaking kind/bug kind/build kind/dependencies kind/docs kind/driver kind/enhancement kind/feature kind/performance kind/proposal kind/proposal:accepted kind/question kind/refactor kind/regression kind/testing kind/upstream need/feedback need/test RaspBerry Pi skip-changelog wip wontfix

Milestone

Set milestone

Clear milestone

No items

No Milestone

1.3.1

Assignees

Assign users

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Write Preview

Loading…

Cancel

Save

There is no content yet.