Change schemas.Column to use int64 #2160

zeripath · 2022-07-12T17:54:02Z

zeripath commented

2022-07-12 17:54:02 +00:00

The largest size of a column in SQL is above the largest integer that
can be stored in an int/int32. Running go on a 32bit machine will result
in ints being mapped to int32 and thus interpretting the schema will
fail.

In this PR we change the schema.Column to use int64 which will allow
Gitea to fix https://github.com/go-gitea/gitea/issues/20161

Signed-off-by: Andrew Thornton art27@cantab.net

The largest size of a column in SQL is above the largest integer that can be stored in an int/int32. Running go on a 32bit machine will result in ints being mapped to int32 and thus interpretting the schema will fail. In this PR we change the schema.Column to use int64 which will allow Gitea to fix https://github.com/go-gitea/gitea/issues/20161 Signed-off-by: Andrew Thornton <art27@cantab.net>

zeripath added 1 commit 2022-07-12 17:54:03 +00:00

Change schemas.Column to use int64

The largest size of a column in SQL is above the largest integer that
can be stored in an int/int32. Running go on a 32bit machine will result
in ints being mapped to int32 and thus interpretting the schema will
fail.

In this PR we change the schema.Column to use int64 which will allow
Gitea to fix https://github.com/go-gitea/gitea/issues/20161

Signed-off-by: Andrew Thornton <art27@cantab.net>

continuous-integration/drone/pr Build is failing

Details

72bfadeefd

wxiaoguang commented

2022-07-13 00:21:59 +00:00

First-time contributor

    engine_test.go:318: 

        	Error Trace:	engine_test.go:318

        	Error:      	Not equal: 

        	            	expected: int64(65535)

        	            	actual  : int(65535)

        	Test:       	TestGetColumnsLength

--- FAIL: TestGetColumnsLength (0.06s)

``` engine_test.go:318: Error Trace: engine_test.go:318 Error: Not equal: expected: int64(65535) actual : int(65535) Test: TestGetColumnsLength --- FAIL: TestGetColumnsLength (0.06s) ```

lunny added the

kind

bug

label 2022-07-13 01:33:27 +00:00

lunny approved these changes 2022-07-13 01:46:47 +00:00

lunny left a comment

Except tests

wxiaoguang approved these changes 2022-07-13 06:35:28 +00:00

zeripath added 1 commit 2022-07-13 19:28:48 +00:00

fix test

Signed-off-by: Andrew Thornton <art27@cantab.net>

continuous-integration/drone/pr Build is failing

Details

9278b05d7e

zeripath commented

2022-07-13 19:29:13 +00:00

Fixed the test.

zeripath added 1 commit 2022-07-13 19:58:38 +00:00

come on drone

Signed-off-by: Andrew Thornton <art27@cantab.net>

continuous-integration/drone/pr Build is failing

Details

f34f97d15b

zeripath commented

2022-07-13 20:05:32 +00:00

now it seems like drone is playing up.

zeripath added 1 commit 2022-07-13 20:19:21 +00:00

come on drone 2

Signed-off-by: Andrew Thornton <art27@cantab.net>

continuous-integration/drone/pr Build is passing

Details

1f504c6518

lunny merged commit c3bce55620 into master

2022-07-14 05:55:24 +00:00

lunny referenced this issue from a commit

2022-07-14 05:55:25 +00:00

Change schemas.Column to use int64 (#2160)

lunny added this to the 1.3.2 milestone 2022-07-14 05:55:33 +00:00

zeripath deleted branch length-as-int64

2022-07-14 08:56:57 +00:00

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#2160