parse timestamp with milliseconds in tz format #2246

agarcia · 2023-04-06T10:24:19Z

agarcia commented

2023-04-06 10:24:19 +00:00

This pr fixes a bug caused when a timestmap in TZ format with milliseconds (2023-04-05T15:50:48.256816Z or 2023-04-05T15:50:48.256816+08:00) is being parsed.

The bug is happens in the function String2Time in convert/time.go
if the timestamp contains milliseconds a layout with the structure 2006-01-02 15:04:05. is used to parse it
This layout contains an space between the date and the hour, if the timestamp returned by the db contains a T the parser fails and an error is returned

This pr adds a check for the T and milliseconds in the timestamp, if both conditions are present the date is parsed using the RFC3339 layout

Added test cases to check timestamps in this format

Solves #2244

This pr fixes a bug caused when a timestmap in TZ format with milliseconds (`2023-04-05T15:50:48.256816Z` or `2023-04-05T15:50:48.256816+08:00`) is being parsed. - The bug is happens in the function `String2Time` in `convert/time.go` - if the timestamp contains milliseconds a layout with the structure `2006-01-02 15:04:05.` is used to parse it - This layout contains an space between the date and the hour, if the timestamp returned by the db contains a `T` the parser fails and an error is returned This pr adds a check for the `T` and milliseconds in the timestamp, if both conditions are present the date is parsed using the RFC3339 layout Added test cases to check timestamps in this format Solves [#2244](https://gitea.com/xorm/xorm/issues/2244)

agarcia added 2 commits 2023-04-06 10:24:20 +00:00

added checks for dates with millisecond format e71b995a84

removed redundant if check

continuous-integration/drone/pr Build is failing

Details

f9cc6d7b21

agarcia changed title from ~~fix-parse-timestamp-milliseconds-TZ-format~~ to fix: parse timestamp with milliseconds in tz format

2023-04-06 10:26:17 +00:00

agarcia changed title from ~~fix: parse timestamp with milliseconds in tz format~~ to WIP: parse timestamp with milliseconds in tz format

2023-04-06 10:40:18 +00:00

agarcia added 1 commit 2023-04-06 10:54:56 +00:00

check pipeline