xorm
/
xorm
62
319
Fork 173
Code Issues 341 Pull Requests 55 Actions Releases 29 Activity

parse timestamp with milliseconds in tz format #2246

Merged
lunny merged 3 commits from agarcia/xorm:fix-parse-timestamp-milliseconds-TZ-format into master 2023-04-06 13:48:00 +00:00
Conversation 0 Commits 3 Files Changed 2
agarcia commented 2023-04-06 10:24:19 +00:00

This pr fixes a bug caused when a timestmap in TZ format with milliseconds (2023-04-05T15:50:48.256816Z or 2023-04-05T15:50:48.256816+08:00) is being parsed.

  • The bug is happens in the function String2Time in convert/time.go
  • if the timestamp contains milliseconds a layout with the structure 2006-01-02 15:04:05. is used to parse it
  • This layout contains an space between the date and the hour, if the timestamp returned by the db contains a T the parser fails and an error is returned

This pr adds a check for the T and milliseconds in the timestamp, if both conditions are present the date is parsed using the RFC3339 layout

Added test cases to check timestamps in this format

Solves #2244

This pr fixes a bug caused when a timestmap in TZ format with milliseconds (`2023-04-05T15:50:48.256816Z` or `2023-04-05T15:50:48.256816+08:00`) is being parsed. - The bug is happens in the function `String2Time` in `convert/time.go` - if the timestamp contains milliseconds a layout with the structure `2006-01-02 15:04:05.` is used to parse it - This layout contains an space between the date and the hour, if the timestamp returned by the db contains a `T` the parser fails and an error is returned This pr adds a check for the `T` and milliseconds in the timestamp, if both conditions are present the date is parsed using the RFC3339 layout Added test cases to check timestamps in this format Solves [#2244](https://gitea.com/xorm/xorm/issues/2244)
agarcia added 2 commits 2023-04-06 10:24:20 +00:00
continuous-integration/drone/pr Build is failing Details
f9cc6d7b21 removed redundant if check
agarcia changed title from fix-parse-timestamp-milliseconds-TZ-format to fix: parse timestamp with milliseconds in tz format 2023-04-06 10:26:17 +00:00
agarcia changed title from fix: parse timestamp with milliseconds in tz format to WIP: parse timestamp with milliseconds in tz format 2023-04-06 10:40:18 +00:00
agarcia added 1 commit 2023-04-06 10:54:56 +00:00
continuous-integration/drone/pr Build is passing Details
5ab6301037 check pipeline
agarcia changed title from WIP: parse timestamp with milliseconds in tz format to parse timestamp with milliseconds in tz format 2023-04-06 11:32:32 +00:00
agarcia requested review from lunny 2023-04-06 11:46:40 +00:00
lunny added the
kind
bug
 label 2023-04-06 12:00:23 +00:00
lunny approved these changes 2023-04-06 12:01:16 +00:00
lunny merged commit 94fcec7f65 into master 2023-04-06 13:48:00 +00:00

Reviewers

lunny approved these changes 2023-04-06 12:01:16 +00:00
Sign in to join this conversation.
Reviewers
Request review
No reviewers
lunny
Labels
Apply labels
Clear labels   
blocked
  
db
oracle
   
db
sqlserver
  
duplicate
  
feature
cache
  
invalid
  
kind
breaking
   
kind
bug
   
kind
build
   
kind
dependencies
   
kind
docs
   
kind
driver
   
kind
enhancement
   
kind
feature
   
kind
performance
   
kind
proposal
   
kind
question
   
kind
refactor
   
kind
testing
  
need
feedback
   
need
test
  
proposal:accepted
   
RaspBerry Pi
   
regression
   
skip-changelog
   
upstream
   
wip
   
wontfix
No Label
blocked
db
oracle
db
sqlserver
duplicate
feature
cache
invalid
kind
breaking
kind
bug
kind
build
kind
dependencies
kind
docs
kind
driver
kind
enhancement
kind
feature
kind
performance
kind
proposal
kind
question
kind
refactor
kind
testing
need
feedback
need
test
proposal:accepted
RaspBerry Pi
regression
skip-changelog
upstream
wip
wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#2246
There is no content yet.
Delete Branch "agarcia/xorm:fix-parse-timestamp-milliseconds-TZ-format"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?