在SQLite3场景下，Sync不支持Modify Column：Error: near MODIFY: syntax error #2267

Merged

lunny merged 17 commits from brookechen/xorm:master into master 2023-07-11 17:10:40 +00:00

Conversation 5 Commits 17 Files Changed 3 +49 -1

brookechen commented 2023-05-19 08:45:38 +00:00

Contributor

Copy Link

rebase

rebase

brookechen added 4 commits 2023-05-19 08:45:39 +00:00

AutoIncrement列带ID插入数据时没有Commit ...

业务场景中，需要预留（1 ~ 100）的ID给系统规则使用。所以会先使用插入将AutoIncrement列的id偏移到一个特定的值（如：100），然后“带ID调用Insert插入系统规则”。 当带ID插入时，由于没有commit，会被rollback掉。

95356ac403

format. bbc89e7511

在SQLite3场景下，modify column不支持：Error: near MODIFY: syntax error d5a0855ace

format 58c7a413a0

brookechen added 1 commit 2023-05-19 08:45:45 +00:00

Merge branch 'master' into master 7b68be0cc3

brookechen added 1 commit 2023-05-19 09:37:36 +00:00

提交注释 46928a07ba

brookechen changed title from master to 在SQLite3场景下，Sync不支持Modify Column：Error: near MODIFY: syntax error 2023-05-19 09:39:31 +00:00

lunny added 1 commit 2023-05-25 10:49:23 +00:00

Merge branch 'master' into master 42bb41f142

brookechen added 1 commit 2023-05-30 02:59:04 +00:00

Merge branch 'master' into master b330b1c715

lunny commented 2023-05-30 13:40:13 +00:00

Owner

Copy Link

Could you give some tests?

Could you give some tests?

brookechen added 1 commit 2023-06-02 01:51:05 +00:00

Merge branch 'master' into master 926f7f90b8

brookechen added 1 commit 2023-06-02 02:07:56 +00:00

add modify column comment testcase 1eed9610ae

brookechen commented 2023-06-02 02:11:16 +00:00

Author

Contributor

Copy Link

Could you give some tests?

实际这是一个功能缺失导致的bug。
目前xorm的Dialect实现中，只有postgres.ModifyColumnSQL实现了修改comment能力。

这个用例在非 postgres上执行时，只能验证多次Sync时，不出错误。而在sqlite3上，原有版本会出现如下错误：

[xorm] [info]  2023/06/02 10:10:46.059528 [SQL] SELECT sql FROM sqlite_master WHERE type='table' and name = ? [test_comment_struct] - 9.208µs
[xorm] [info]  2023/06/02 10:10:46.059581 [SQL] SELECT sql FROM sqlite_master WHERE type='index' and tbl_name = ? [test_comment_struct] - 7.25µs
[xorm] [info]  2023/06/02 10:10:46.059615 [SQL] ALTER TABLE `test_comment_struct` MODIFY COLUMN `has_comment` INTEGER NULL [] - 13.834µs
    engine_test.go:311: 
        	Error Trace:	engine_test.go:311
        	Error:      	Received unexpected error:
        	            	near "MODIFY": syntax error
        	Test:       	TestColumnCommentUpdate
    engine_test.go:316: 
--- FAIL: TestColumnCommentUpdate (0.00s)

> Could you give some tests? 实际这是一个功能缺失导致的bug。 目前xorm的`Dialect`实现中，只有`postgres.ModifyColumnSQL`实现了修改comment能力。 这个用例在非 postgres上执行时，只能验证多次Sync时，不出错误。而在sqlite3上，原有版本会出现如下错误： ``` [xorm] [info] 2023/06/02 10:10:46.059528 [SQL] SELECT sql FROM sqlite_master WHERE type='table' and name = ? [test_comment_struct] - 9.208µs [xorm] [info] 2023/06/02 10:10:46.059581 [SQL] SELECT sql FROM sqlite_master WHERE type='index' and tbl_name = ? [test_comment_struct] - 7.25µs [xorm] [info] 2023/06/02 10:10:46.059615 [SQL] ALTER TABLE `test_comment_struct` MODIFY COLUMN `has_comment` INTEGER NULL [] - 13.834µs engine_test.go:311: Error Trace: engine_test.go:311 Error: Received unexpected error: near "MODIFY": syntax error Test: TestColumnCommentUpdate engine_test.go:316: --- FAIL: TestColumnCommentUpdate (0.00s) ```

brookechen changed title from 在SQLite3场景下，Sync不支持Modify Column：Error: near MODIFY: syntax error to WIP: 在SQLite3场景下，Sync不支持Modify Column：Error: near MODIFY: syntax error 2023-06-02 02:12:23 +00:00

brookechen changed title from WIP: 在SQLite3场景下，Sync不支持Modify Column：Error: near MODIFY: syntax error to 在SQLite3场景下，Sync不支持Modify Column：Error: near MODIFY: syntax error 2023-06-02 02:12:39 +00:00

brookechen added 4 commits 2023-07-10 12:04:39 +00:00

在SQLite3场景下，modify column不支持：Error: near MODIFY: syntax error adbb669cf2

提交注释 8e2ce8c53d

add modify column comment testcase b0fe86421a

Merge branch 'xorm-master' a678ef1c27

brookechen added 1 commit 2023-07-10 12:07:24 +00:00

merge origin master 0b9bf4f167

lunny commented 2023-07-11 01:14:41 +00:00

Owner

Copy Link

I think both MySQL and postgres supports change the comment? Maybe you need to add MySQL too.

I think both MySQL and postgres supports change the comment? Maybe you need to add MySQL too.

brookechen added 1 commit 2023-07-11 08:43:04 +00:00

cockroach db create table with integer column but get from db is bigint 604489eb38

brookechen added 1 commit 2023-07-11 09:18:49 +00:00

mysql alter column comment ready. a019b1ea33

brookechen commented 2023-07-11 09:19:45 +00:00

Author

Contributor

Copy Link

I think both MySQL and postgres supports change the comment? Maybe you need to add MySQL too.

原来的mysql dialect 逻辑不支持 alter column comment 的，现在我加上了，请 CR

> I think both MySQL and postgres supports change the comment? Maybe you need to add MySQL too. 原来的mysql dialect 逻辑不支持 alter column comment 的，现在我加上了，请 CR

brookechen commented 2023-07-11 09:28:32 +00:00

Author

Contributor

Copy Link

另外，发现个问题：数据库为cockroach时， 当 struct column 类型为 int 时，create 语句时是设置的 has_comment 列为 INTEGER 类型，但是再查询时，列类型为 BIGINT，导致用例失败，因此先将用例中 has_comment 列设置为 bigint。cockroach 的数据类型问题另外跟进。

相关 sql 如下：

CREATE TABLE IF NOT EXISTS "public"."test_comment_struct" ("has_comment" INTEGER NULL); COMMENT ON COLUMN "public"."test_comment_struct"."has_comment" IS 'this is a comment before update'; [] - 23.943542ms

SELECT column_name, column_default, is_nullable, data_type, character_maximum_length, description,
CASE WHEN p.contype = 'p' THEN true ELSE false END AS primarykey,
CASE WHEN p.contype = 'u' THEN true ELSE false END AS uniquekey
FROM pg_attribute f
JOIN pg_class c ON c.oid = f.attrelid JOIN pg_type t ON t.oid = f.atttypid
LEFT JOIN pg_attrdef d ON d.adrelid = c.oid AND d.adnum = f.attnum
LEFT JOIN pg_description de ON f.attrelid=de.objoid AND f.attnum=de.objsubid
LEFT JOIN pg_namespace n ON n.oid = c.relnamespace
LEFT JOIN pg_constraint p ON p.conrelid = c.oid AND f.attnum = ANY (p.conkey)
LEFT JOIN pg_class AS g ON p.confrelid = g.oid
LEFT JOIN INFORMATION_SCHEMA.COLUMNS s ON s.column_name=f.attname AND c.relname=s.table_name
WHERE n.nspname= s.table_schema AND c.relkind = 'r' AND c.relname = $1 AND s.table_schema = $2 AND f.attnum > 0 ORDER BY f.attnum; [test_comment_struct public]

另外，发现个问题：数据库为cockroach时， 当 struct column 类型为 int 时，create 语句时是设置的 has_comment 列为 INTEGER 类型，但是再查询时，列类型为 BIGINT，导致用例失败，因此先将用例中 has_comment 列设置为 bigint。cockroach 的数据类型问题另外跟进。 相关 sql 如下： CREATE TABLE IF NOT EXISTS "public"."test_comment_struct" ("has_comment" INTEGER NULL); COMMENT ON COLUMN "public"."test_comment_struct"."has_comment" IS 'this is a comment before update'; [] - 23.943542ms SELECT column_name, column_default, is_nullable, data_type, character_maximum_length, description, CASE WHEN p.contype = 'p' THEN true ELSE false END AS primarykey, CASE WHEN p.contype = 'u' THEN true ELSE false END AS uniquekey FROM pg_attribute f JOIN pg_class c ON c.oid = f.attrelid JOIN pg_type t ON t.oid = f.atttypid LEFT JOIN pg_attrdef d ON d.adrelid = c.oid AND d.adnum = f.attnum LEFT JOIN pg_description de ON f.attrelid=de.objoid AND f.attnum=de.objsubid LEFT JOIN pg_namespace n ON n.oid = c.relnamespace LEFT JOIN pg_constraint p ON p.conrelid = c.oid AND f.attnum = ANY (p.conkey) LEFT JOIN pg_class AS g ON p.confrelid = g.oid LEFT JOIN INFORMATION_SCHEMA.COLUMNS s ON s.column_name=f.attname AND c.relname=s.table_name WHERE n.nspname= s.table_schema AND c.relkind = 'r' AND c.relname = $1 AND s.table_schema = $2 AND f.attnum > 0 ORDER BY f.attnum; [test_comment_struct public]

lunny added the

kind

bug

label 2023-07-11 09:54:46 +00:00

lunny approved these changes 2023-07-11 17:09:56 +00:00

lunny merged commit 486c344ba3 into master 2023-07-11 17:10:40 +00:00

lunny referenced this issue from a commit 2023-07-11 17:10:44 +00:00

In SQLite3, Sync doesn't support Modify Column：Error: near MODIFY: syntax error (#2267)

lunny added this to the 1.3.3 milestone 2023-07-26 01:30:30 +00:00

martinvigg referenced this issue from a commit 2023-10-09 15:32:50 +00:00

In SQLite3, Sync doesn't support Modify Column：Error: near MODIFY: syntax error (#2267)

Sign in to join this conversation.

Reviewers

No reviewers

lunny

Labels

Clear labels   

backport/done

  

backport/v1

  

blocked

  

db

oracle

  

db

sqlserver

  

duplicate

  

feature

cache

  

frontport/done

  

frontport/main

  

invalid

  

kind

breaking

  

kind

bug

  

kind

build

  

kind

dependencies

  

kind

docs

  

kind

driver

  

kind

enhancement

  

kind

feature

  

kind

performance

  

kind

proposal

  

kind

question

  

kind

refactor

  

kind

testing

  

need

feedback

  

need

test

  

proposal:accepted

  

RaspBerry Pi

  

regression

  

skip-changelog

  

upstream

  

wip

  

wontfix

No Label

backport/done

backport/v1

blocked

db

oracle

db

sqlserver

duplicate

feature

cache

frontport/done

frontport/main

invalid

kind

breaking

kind

bug

kind

build

kind

dependencies

kind

docs

kind

driver

kind

enhancement

kind

feature

kind

performance

kind

proposal

kind

question

kind

refactor

kind

testing

need

feedback

need

test

proposal:accepted

RaspBerry Pi

regression

skip-changelog

upstream

wip

wontfix

Milestone

Clear milestone

No items

No Milestone

1.3.3

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#2267

No description provided.