xorm/xorm
xorm/xorm
63
355
Fork 204
Code Issues 369 Pull Requests 15 Actions Releases 35 Activity

Add concurrent table update test #561

Closed
typeless wants to merge 1 commits from test-concurrent-table-update into master
pull from: test-concurrent-table-update
merge into: xorm:master
Conversation 0 Commits 1 Files Changed 1 +33
typeless commented 2017-04-08 12:41:29 +00:00 (Migrated from github.com)
Copy Link

The test can trigger data race, along with messages about the database is locked.

==================                                                                                                                                                                                 [91/1861]
WARNING: DATA RACE
Read at 0x00c420107a40 by goroutine 47:
  reflect.typedmemmove()
      /Users/mura/t/go1.8.1/src/runtime/mbarrier.go:253 +0x0
  reflect.packEface()
      /Users/mura/t/go1.8.1/src/reflect/value.go:112 +0x11c
  reflect.valueInterface()
      /Users/mura/t/go1.8.1/src/reflect/value.go:955 +0x18c
  reflect.Value.Interface()
      /Users/mura/t/go1.8.1/src/reflect/value.go:925 +0x51
  github.com/go-xorm/xorm.(*Engine).tbName()
      /Users/mura/.go/src/github.com/go-xorm/xorm/engine.go:554 +0x50
  github.com/go-xorm/xorm.(*Statement).setRefValue()
      /Users/mura/.go/src/github.com/go-xorm/xorm/statement.go:216 +0x188
  github.com/go-xorm/xorm.(*Session).innerInsert()
      /Users/mura/.go/src/github.com/go-xorm/xorm/session_insert.go:300 +0xc1
  github.com/go-xorm/xorm.(*Session).Insert()
      /Users/mura/.go/src/github.com/go-xorm/xorm/session_insert.go:49 +0x37f
  github.com/go-xorm/xorm.(*Engine).Insert()
      /Users/mura/.go/src/github.com/go-xorm/xorm/engine.go:1384 +0xb1
  github.com/go-xorm/xorm.TestUpdateMapConcurrently.func1()
      /Users/mura/.go/src/github.com/go-xorm/xorm/session_update_test.go:98 +0xc9

Previous write at 0x00c420107a40 by goroutine 12:
  reflect.typedmemmove()
      /Users/mura/t/go1.8.1/src/runtime/mbarrier.go:253 +0x0
  reflect.Value.Set()
      /Users/mura/t/go1.8.1/src/reflect/value.go:1353 +0xe9
  github.com/go-xorm/xorm.(*Session).innerInsert()
      /Users/mura/.go/src/github.com/go-xorm/xorm/session_insert.go:511 +0x1782
  github.com/go-xorm/xorm.(*Session).Insert()
      /Users/mura/.go/src/github.com/go-xorm/xorm/session_insert.go:49 +0x37f
  github.com/go-xorm/xorm.(*Engine).Insert()
      /Users/mura/.go/src/github.com/go-xorm/xorm/engine.go:1384 +0xb1
  github.com/go-xorm/xorm.TestUpdateMapConcurrently.func1()
      /Users/mura/.go/src/github.com/go-xorm/xorm/session_update_test.go:98 +0xc9

Goroutine 47 (running) created at:
  github.com/go-xorm/xorm.TestUpdateMapConcurrently()
      /Users/mura/.go/src/github.com/go-xorm/xorm/session_update_test.go:104 +0x2ab
  testing.tRunner()
      /Users/mura/t/go1.8.1/src/testing/testing.go:657 +0x107

Goroutine 12 (running) created at:
  github.com/go-xorm/xorm.TestUpdateMapConcurrently()
      /Users/mura/.go/src/github.com/go-xorm/xorm/session_update_test.go:104 +0x2ab
  testing.tRunner()
      /Users/mura/t/go1.8.1/src/testing/testing.go:657 +0x107
==================
The test can trigger data race, along with messages about the database is locked. ``` ================== [91/1861] WARNING: DATA RACE Read at 0x00c420107a40 by goroutine 47: reflect.typedmemmove() /Users/mura/t/go1.8.1/src/runtime/mbarrier.go:253 +0x0 reflect.packEface() /Users/mura/t/go1.8.1/src/reflect/value.go:112 +0x11c reflect.valueInterface() /Users/mura/t/go1.8.1/src/reflect/value.go:955 +0x18c reflect.Value.Interface() /Users/mura/t/go1.8.1/src/reflect/value.go:925 +0x51 github.com/go-xorm/xorm.(*Engine).tbName() /Users/mura/.go/src/github.com/go-xorm/xorm/engine.go:554 +0x50 github.com/go-xorm/xorm.(*Statement).setRefValue() /Users/mura/.go/src/github.com/go-xorm/xorm/statement.go:216 +0x188 github.com/go-xorm/xorm.(*Session).innerInsert() /Users/mura/.go/src/github.com/go-xorm/xorm/session_insert.go:300 +0xc1 github.com/go-xorm/xorm.(*Session).Insert() /Users/mura/.go/src/github.com/go-xorm/xorm/session_insert.go:49 +0x37f github.com/go-xorm/xorm.(*Engine).Insert() /Users/mura/.go/src/github.com/go-xorm/xorm/engine.go:1384 +0xb1 github.com/go-xorm/xorm.TestUpdateMapConcurrently.func1() /Users/mura/.go/src/github.com/go-xorm/xorm/session_update_test.go:98 +0xc9 Previous write at 0x00c420107a40 by goroutine 12: reflect.typedmemmove() /Users/mura/t/go1.8.1/src/runtime/mbarrier.go:253 +0x0 reflect.Value.Set() /Users/mura/t/go1.8.1/src/reflect/value.go:1353 +0xe9 github.com/go-xorm/xorm.(*Session).innerInsert() /Users/mura/.go/src/github.com/go-xorm/xorm/session_insert.go:511 +0x1782 github.com/go-xorm/xorm.(*Session).Insert() /Users/mura/.go/src/github.com/go-xorm/xorm/session_insert.go:49 +0x37f github.com/go-xorm/xorm.(*Engine).Insert() /Users/mura/.go/src/github.com/go-xorm/xorm/engine.go:1384 +0xb1 github.com/go-xorm/xorm.TestUpdateMapConcurrently.func1() /Users/mura/.go/src/github.com/go-xorm/xorm/session_update_test.go:98 +0xc9 Goroutine 47 (running) created at: github.com/go-xorm/xorm.TestUpdateMapConcurrently() /Users/mura/.go/src/github.com/go-xorm/xorm/session_update_test.go:104 +0x2ab testing.tRunner() /Users/mura/t/go1.8.1/src/testing/testing.go:657 +0x107 Goroutine 12 (running) created at: github.com/go-xorm/xorm.TestUpdateMapConcurrently() /Users/mura/.go/src/github.com/go-xorm/xorm/session_update_test.go:104 +0x2ab testing.tRunner() /Users/mura/t/go1.8.1/src/testing/testing.go:657 +0x107 ================== ```

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backport/done

   
backport/v1

   
blocked
  
db
oracle

  
db
sqlserver

  
duplicate
  
feature
cache

  
frontport/done

   
frontport/main

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependencies

  
kind
docs

  
kind
driver

  
kind
enhancement

  
kind
feature

  
kind
performance

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
testing

  
need
feedback

  
need
test

  
proposal:accepted

   
RaspBerry Pi

   
regression

   
skip-changelog

   
upstream

   
wip

   
wontfix
No Label
backport/done
backport/v1
blocked
db
oracle
db
sqlserver
duplicate
feature
cache
frontport/done
frontport/main
invalid
kind
breaking
kind
bug
kind
build
kind
dependencies
kind
docs
kind
driver
kind
enhancement
kind
feature
kind
performance
kind
proposal
kind
question
kind
refactor
kind
testing
need
feedback
need
test
proposal:accepted
RaspBerry Pi
regression
skip-changelog
upstream
wip
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#561
No description provided.
Delete Branch "test-concurrent-table-update"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?