xorm/xorm
xorm/xorm
63
355
Fork 204
Code Issues 368 Pull Requests 16 Actions Releases 35 Activity

support different text type with JSON type #646

Closed
lunny wants to merge 2 commits from lunny/json_with_texts into master
pull from: lunny/json_with_texts
merge into: xorm:master
Conversation 2 Commits 2 Files Changed 13 +72 -16
lunny commented 2017-07-20 12:11:59 +00:00
Owner
Copy Link
No description provided.
codecov-io commented 2017-07-20 12:17:01 +00:00 (Migrated from github.com)
Author
Owner
Copy Link

Codecov Report

Merging #646 into master will decrease coverage by 1.52%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #646      +/-   ##
==========================================
- Coverage   49.67%   48.14%   -1.53%     
==========================================
  Files          34       34              
  Lines        7090     8370    +1280     
==========================================
+ Hits         3522     4030     +508     
- Misses       3085     3853     +768     
- Partials      483      487       +4
Impacted Files Coverage Δ
dialect_mysql.go 54.96% <ø> (-0.75%) ⬇️
engine.go 54.11% <ø> (-2.83%) ⬇️
engine_cond.go 52.72% <0%> (+0.06%) ⬆️
dialect_mssql.go 0% <0%> (ø) ⬆️
session.go 48.55% <0%> (-1.76%) ⬇️
dialect_oracle.go 0% <0%> (ø) ⬆️
session_convert.go 20.27% <100%> (-1.26%) ⬇️
statement.go 62.07% <100%> (-1.05%) ⬇️
dialect_sqlite3.go 76.49% <100%> (-1.56%) ⬇️
tag.go 70.65% <100%> (+2.71%) ⬆️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 774f83c...0708a56. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/646?src=pr&el=h1) Report > Merging [#646](https://codecov.io/gh/go-xorm/xorm/pull/646?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/774f83c1bc04aca2a136270778d70ba0212d25d5?src=pr&el=desc) will **decrease** coverage by `1.52%`. > The diff coverage is `60%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/646/graphs/tree.svg?src=pr&token=yB5nO1krEe&width=650&height=150)](https://codecov.io/gh/go-xorm/xorm/pull/646?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #646 +/- ## ========================================== - Coverage 49.67% 48.14% -1.53% ========================================== Files 34 34 Lines 7090 8370 +1280 ========================================== + Hits 3522 4030 +508 - Misses 3085 3853 +768 - Partials 483 487 +4 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/646?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [dialect\_mysql.go](https://codecov.io/gh/go-xorm/xorm/pull/646/diff?src=pr&el=tree#diff-ZGlhbGVjdF9teXNxbC5nbw==) | `54.96% <ø> (-0.75%)` | :arrow_down: | | [engine.go](https://codecov.io/gh/go-xorm/xorm/pull/646/diff?src=pr&el=tree#diff-ZW5naW5lLmdv) | `54.11% <ø> (-2.83%)` | :arrow_down: | | [engine\_cond.go](https://codecov.io/gh/go-xorm/xorm/pull/646/diff?src=pr&el=tree#diff-ZW5naW5lX2NvbmQuZ28=) | `52.72% <0%> (+0.06%)` | :arrow_up: | | [dialect\_mssql.go](https://codecov.io/gh/go-xorm/xorm/pull/646/diff?src=pr&el=tree#diff-ZGlhbGVjdF9tc3NxbC5nbw==) | `0% <0%> (ø)` | :arrow_up: | | [session.go](https://codecov.io/gh/go-xorm/xorm/pull/646/diff?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `48.55% <0%> (-1.76%)` | :arrow_down: | | [dialect\_oracle.go](https://codecov.io/gh/go-xorm/xorm/pull/646/diff?src=pr&el=tree#diff-ZGlhbGVjdF9vcmFjbGUuZ28=) | `0% <0%> (ø)` | :arrow_up: | | [session\_convert.go](https://codecov.io/gh/go-xorm/xorm/pull/646/diff?src=pr&el=tree#diff-c2Vzc2lvbl9jb252ZXJ0Lmdv) | `20.27% <100%> (-1.26%)` | :arrow_down: | | [statement.go](https://codecov.io/gh/go-xorm/xorm/pull/646/diff?src=pr&el=tree#diff-c3RhdGVtZW50Lmdv) | `62.07% <100%> (-1.05%)` | :arrow_down: | | [dialect\_sqlite3.go](https://codecov.io/gh/go-xorm/xorm/pull/646/diff?src=pr&el=tree#diff-ZGlhbGVjdF9zcWxpdGUzLmdv) | `76.49% <100%> (-1.56%)` | :arrow_down: | | [tag.go](https://codecov.io/gh/go-xorm/xorm/pull/646/diff?src=pr&el=tree#diff-dGFnLmdv) | `70.65% <100%> (+2.71%)` | :arrow_up: | | ... and [31 more](https://codecov.io/gh/go-xorm/xorm/pull/646/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/646?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/646?src=pr&el=footer). Last update [774f83c...0708a56](https://codecov.io/gh/go-xorm/xorm/pull/646?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
lunny modified the milestone from 0.8 to 0.8.2 2019-10-21 03:49:16 +00:00
lunny modified the milestone from 0.8.2 to 1.3.0 2020-01-20 08:25:39 +00:00
lunny modified the milestone from 1.3.0 to 2.0.0 2021-10-20 00:56:27 +00:00
lunny commented 2023-07-22 15:13:07 +00:00
Author
Owner
Copy Link

outdated.

outdated.
lunny closed this pull request 2023-07-22 15:13:08 +00:00
lunny removed this from the 2.0.0 milestone 2023-07-26 01:27:32 +00:00
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backport/done

   
backport/v1

   
blocked
  
db
oracle

  
db
sqlserver

  
duplicate
  
feature
cache

  
frontport/done

   
frontport/main

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependencies

  
kind
docs

  
kind
driver

  
kind
enhancement

  
kind
feature

  
kind
performance

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
testing

  
need
feedback

  
need
test

  
proposal:accepted

   
RaspBerry Pi

   
regression

   
skip-changelog

   
upstream

   
wip

   
wontfix
No Label
backport/done
backport/v1
blocked
db
oracle
db
sqlserver
duplicate
feature
cache
frontport/done
frontport/main
invalid
kind
breaking
kind
bug
kind
build
kind
dependencies
kind
docs
kind
driver
kind
enhancement
kind
feature
kind
performance
kind
proposal
kind
question
kind
refactor
kind
testing
need
feedback
need
test
proposal:accepted
RaspBerry Pi
regression
skip-changelog
upstream
wip
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#646
No description provided.
Delete Branch "lunny/json_with_texts"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?