refactor query functions #689

lunny · 2017-08-22T06:30:14Z

lunny commented

2017-08-22 06:30:14 +00:00

No description provided.

codecov-io commented

2017-08-22 06:32:18 +00:00

(Migrated from github.com)

Codecov Report

Merging #689 into master will decrease coverage by 0.08%.
The diff coverage is 65.69%.

@@            Coverage Diff             @@
##           master     #689      +/-   ##
==========================================
- Coverage   49.14%   49.06%   -0.09%     
==========================================
  Files          34       34              
  Lines        8314     8185     -129     
==========================================
- Hits         4086     4016      -70     
+ Misses       3748     3698      -50     
+ Partials      480      471       -9

Impacted Files	Coverage Δ
engine.go	`54.52% <ø> (+0.2%)`	⬆️
session_convert.go	`20.24% <0%> (-0.04%)`	⬇️
session_delete.go	`38.42% <0%> (-0.33%)`	⬇️
session.go	`52.32% <100%> (+3.17%)`	⬆️
session_exist.go	`60.37% <100%> (-0.28%)`	⬇️
session_iterate.go	`64% <100%> (+4.9%)`	⬆️
session_stats.go	`67.74% <100%> (+4.45%)`	⬆️
rows.go	`49.36% <20%> (+0.31%)`	⬆️
session_insert.go	`54.52% <50%> (-1.57%)`	⬇️
session_update.go	`49.02% <50%> (-0.33%)`	⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7f04c3...80094c0. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/689?src=pr&el=h1) Report > Merging [#689](https://codecov.io/gh/go-xorm/xorm/pull/689?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/d7f04c3cecff8d8c9321b2c39940e1992ce9f01a?src=pr&el=desc) will **decrease** coverage by `0.08%`. > The diff coverage is `65.69%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/689/graphs/tree.svg?width=650&height=150&src=pr&token=yB5nO1krEe)](https://codecov.io/gh/go-xorm/xorm/pull/689?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #689 +/- ## ========================================== - Coverage 49.14% 49.06% -0.09% ========================================== Files 34 34 Lines 8314 8185 -129 ========================================== - Hits 4086 4016 -70 + Misses 3748 3698 -50 + Partials 480 471 -9 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/689?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [engine.go](https://codecov.io/gh/go-xorm/xorm/pull/689?src=pr&el=tree#diff-ZW5naW5lLmdv) | `54.52% <ø> (+0.2%)` | :arrow_up: | | [session\_convert.go](https://codecov.io/gh/go-xorm/xorm/pull/689?src=pr&el=tree#diff-c2Vzc2lvbl9jb252ZXJ0Lmdv) | `20.24% <0%> (-0.04%)` | :arrow_down: | | [session\_delete.go](https://codecov.io/gh/go-xorm/xorm/pull/689?src=pr&el=tree#diff-c2Vzc2lvbl9kZWxldGUuZ28=) | `38.42% <0%> (-0.33%)` | :arrow_down: | | [session.go](https://codecov.io/gh/go-xorm/xorm/pull/689?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `52.32% <100%> (+3.17%)` | :arrow_up: | | [session\_exist.go](https://codecov.io/gh/go-xorm/xorm/pull/689?src=pr&el=tree#diff-c2Vzc2lvbl9leGlzdC5nbw==) | `60.37% <100%> (-0.28%)` | :arrow_down: | | [session\_iterate.go](https://codecov.io/gh/go-xorm/xorm/pull/689?src=pr&el=tree#diff-c2Vzc2lvbl9pdGVyYXRlLmdv) | `64% <100%> (+4.9%)` | :arrow_up: | | [session\_stats.go](https://codecov.io/gh/go-xorm/xorm/pull/689?src=pr&el=tree#diff-c2Vzc2lvbl9zdGF0cy5nbw==) | `67.74% <100%> (+4.45%)` | :arrow_up: | | [rows.go](https://codecov.io/gh/go-xorm/xorm/pull/689?src=pr&el=tree#diff-cm93cy5nbw==) | `49.36% <20%> (+0.31%)` | :arrow_up: | | [session\_insert.go](https://codecov.io/gh/go-xorm/xorm/pull/689?src=pr&el=tree#diff-c2Vzc2lvbl9pbnNlcnQuZ28=) | `54.52% <50%> (-1.57%)` | :arrow_down: | | [session\_update.go](https://codecov.io/gh/go-xorm/xorm/pull/689?src=pr&el=tree#diff-c2Vzc2lvbl91cGRhdGUuZ28=) | `49.02% <50%> (-0.33%)` | :arrow_down: | | ... and [12 more](https://codecov.io/gh/go-xorm/xorm/pull/689?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/689?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/689?src=pr&el=footer). Last update [d7f04c3...80094c0](https://codecov.io/gh/go-xorm/xorm/pull/689?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny referenced this issue from a commit

2019-10-21 05:46:59 +00:00

refactor query functions (#689) * refactor query functions * remove unused function * remove unnecessary resetStatement and some improvements * rename all Id to ID

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#689