#791 Remove some unnecessary debug log and some refactor

Merged
lunny merged 1 commits from lunny/some_refactoring into master 2 years ago
lunny commented 2 years ago
There is no content yet.
codecov-io commented 2 years ago (Migrated from github.com)
Owner

Codecov Report

Merging #791 into master will increase coverage by 0.04%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #791      +/-   ##
==========================================
+ Coverage   53.18%   53.22%   +0.04%     
==========================================
  Files          39       39              
  Lines        7326     7318       -8     
==========================================
- Hits         3896     3895       -1     
+ Misses       2935     2929       -6     
+ Partials      495      494       -1
Impacted Files Coverage Δ
session_convert.go 21.65% <ø> (-0.11%) :arrow_down:
convert.go 28.96% <0%> (+0.11%) :arrow_up:
xorm.go 70% <0%> (+1.66%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b6ba097...a79b2c9. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/791?src=pr&el=h1) Report > Merging [#791](https://codecov.io/gh/go-xorm/xorm/pull/791?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/b6ba097a503de9d71f3250bad2a949556c599fd6?src=pr&el=desc) will **increase** coverage by `0.04%`. > The diff coverage is `0%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/791/graphs/tree.svg?token=yB5nO1krEe&src=pr&height=150&width=650)](https://codecov.io/gh/go-xorm/xorm/pull/791?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #791 +/- ## ========================================== + Coverage 53.18% 53.22% +0.04% ========================================== Files 39 39 Lines 7326 7318 -8 ========================================== - Hits 3896 3895 -1 + Misses 2935 2929 -6 + Partials 495 494 -1 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/791?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [session\_convert.go](https://codecov.io/gh/go-xorm/xorm/pull/791/diff?src=pr&el=tree#diff-c2Vzc2lvbl9jb252ZXJ0Lmdv) | `21.65% <ø> (-0.11%)` | :arrow_down: | | [convert.go](https://codecov.io/gh/go-xorm/xorm/pull/791/diff?src=pr&el=tree#diff-Y29udmVydC5nbw==) | `28.96% <0%> (+0.11%)` | :arrow_up: | | [xorm.go](https://codecov.io/gh/go-xorm/xorm/pull/791/diff?src=pr&el=tree#diff-eG9ybS5nbw==) | `70% <0%> (+1.66%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/791?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/791?src=pr&el=footer). Last update [b6ba097...a79b2c9](https://codecov.io/gh/go-xorm/xorm/pull/791?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
The pull request has been merged as d75e4924db.
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
Cancel
Save
There is no content yet.