xorm/dialects
antialiasis 44f892fddc Ignore comments when deciding when to replace question marks. #1954 (#1955)
This should solve #1954 and adds some tests for it. I will note I'm not 100% clear on whether there are other edge cases that should be covered here. From what I understand the only standard SQL way to escape single quotes is to double them, which shouldn't cause any problems with this, but if some SQL flavors allow other kinds of escaping, for instance, that would probably need to be covered too for ideal results.

Co-authored-by: Hlín Önnudóttir <hlin@nanitor.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Reviewed-on: xorm/xorm#1955
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: antialiasis <antialiasis@noreply.gitea.io>
Co-committed-by: antialiasis <antialiasis@noreply.gitea.io>
2021-06-26 19:19:13 +08:00
..
dialect.go Add DBVersion (#1723) 2021-06-12 15:06:05 +08:00
driver.go Fix comments (#1893) 2021-04-12 09:19:08 +08:00
filter_test.go Ignore comments when deciding when to replace question marks. #1954 (#1955) 2021-06-26 19:19:13 +08:00
filter.go Ignore comments when deciding when to replace question marks. #1954 (#1955) 2021-06-26 19:19:13 +08:00
gen_reserved.sh Move reserve words related files into dialects sub package (#1544) 2020-02-24 10:05:10 +00:00
mssql_test.go Merge core package back into the main repository and split into serval sub packages. (#1543) 2020-02-24 08:53:18 +00:00
mssql.go Add DBVersion (#1723) 2021-06-12 15:06:05 +08:00
mysql.go Add DBVersion (#1723) 2021-06-12 15:06:05 +08:00
oracle_test.go Oracle : Local Naming Method (#1515) 2020-03-23 02:03:04 +00:00
oracle.go Add DBVersion (#1723) 2021-06-12 15:06:05 +08:00
pg_reserved.txt Move reserve words related files into dialects sub package (#1544) 2020-02-24 10:05:10 +00:00
postgres_test.go Merge core package back into the main repository and split into serval sub packages. (#1543) 2020-02-24 08:53:18 +00:00
postgres.go fix pg GetColumns missing comment (#1949) 2021-06-12 22:47:15 +08:00
quote.go Improve quote policy (#1567) 2020-03-06 07:48:32 +00:00
sqlite3_test.go Merge core package back into the main repository and split into serval sub packages. (#1543) 2020-02-24 08:53:18 +00:00
sqlite3.go Add DBVersion (#1723) 2021-06-12 15:06:05 +08:00
table_name_test.go Move statement as a sub package (#1564) 2020-02-28 12:29:08 +00:00
table_name.go Fix postgres schema problem (#1624) 2020-03-25 09:36:45 +00:00
time.go Fix comments (#1893) 2021-04-12 09:19:08 +08:00