ee8bd4ece4
* MM-23250: improve config.Migrate tests The config.Migrate tests were not running in isolation, but wrote over the "local" config. The test coverage for both directions was not exhaustive, and lacked coverage for the recently added plugin signature files. Rewrite the unit tests as such, fixing a minor issue closing the stores after migration. Fixes: https://mattermost.atlassian.net/browse/MM-23250 * idiomatic err checking * clarify random file contents Co-authored-by: mattermod <mattermod@users.noreply.github.com>
63 lines
1.6 KiB
Go
63 lines
1.6 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package config
|
|
|
|
import "github.com/pkg/errors"
|
|
|
|
// Migrate migrates SAML keys and certificates from one store to another given their data source names.
|
|
func Migrate(from, to string) error {
|
|
source, err := NewStore(from, false)
|
|
if err != nil {
|
|
return errors.Wrapf(err, "failed to access source config %s", from)
|
|
}
|
|
defer source.Close()
|
|
|
|
destination, err := NewStore(to, false)
|
|
if err != nil {
|
|
return errors.Wrapf(err, "failed to access destination config %s", to)
|
|
}
|
|
defer destination.Close()
|
|
|
|
sourceConfig := source.Get()
|
|
if _, err = destination.Set(sourceConfig); err != nil {
|
|
return errors.Wrapf(err, "failed to set config")
|
|
}
|
|
|
|
files := []string{
|
|
*sourceConfig.SamlSettings.IdpCertificateFile,
|
|
*sourceConfig.SamlSettings.PublicCertificateFile,
|
|
*sourceConfig.SamlSettings.PrivateKeyFile,
|
|
}
|
|
|
|
files = append(files, sourceConfig.PluginSettings.SignaturePublicKeyFiles...)
|
|
|
|
for _, file := range files {
|
|
if err := migrateFile(file, source, destination); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func migrateFile(name string, source Store, destination Store) error {
|
|
fileExists, err := source.HasFile(name)
|
|
if err != nil {
|
|
return errors.Wrapf(err, "failed to check existence of %s", name)
|
|
}
|
|
|
|
if fileExists {
|
|
file, err := source.GetFile(name)
|
|
if err != nil {
|
|
return errors.Wrapf(err, "failed to migrate %s", name)
|
|
}
|
|
err = destination.SetFile(name, file)
|
|
if err != nil {
|
|
return errors.Wrapf(err, "failed to migrate %s", name)
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|