daisuzu
0 Followers · 0 Following
  • Joined on 2021-08-31
Repositories
1
 Projects Public Activity Starred Repositories
daisuzu commented on pull request xorm/xorm#2040 2021-09-07 02:14:28 +00:00
fix panic when Iterate() fails

Thank you very much.

daisuzu commented on pull request xorm/xorm#2040 2021-09-06 05:37:34 +00:00
fix panic when Iterate() fails

Hi lunny,

If error occurs in L75,

rows.go Lines 75 to 79 in 049d42641f
rows.rows, err = rows.session.queryRows(sqlStr, args...)
if err != nil {
rows.Close()
return nil, err
}

rows.Close() calls rows.Err(), but rows.rows is nil, so…

daisuzu created pull request xorm/xorm#2040 2021-09-06 05:15:24 +00:00
fix panic when Iterate() fails
daisuzu created branch daisuzu-patch-1 in daisuzu/xorm 2021-09-06 05:13:05 +00:00
daisuzu pushed to daisuzu-patch-1 at daisuzu/xorm 2021-09-06 05:13:05 +00:00
049d42641f fix panic when Iterate() fails
daisuzu created repository daisuzu/xorm 2021-09-06 05:04:15 +00:00