Put the job container name into the env context #62

sillyguodong · 2023-06-02T09:22:04Z

sillyguodong commented

2023-06-02 09:22:04 +00:00

Related: gitea/act_runner#189 (comment)
Refer to Docker Doc, the --volumes-from flag is used when running or creating a new container and takes the name or ID of the container from which you want to share volumes. Here's the syntax:

docker run --volumes-from <container_name_or_id> <image>

So put the job container name into the env context in this PR.

Related: https://gitea.com/gitea/act_runner/issues/189#issuecomment-740636 Refer to [Docker Doc](https://docs.docker.com/engine/reference/commandline/run/#volumes-from), the `--volumes-from` flag is used when running or creating a new container and takes the name or ID of the container from which you want to share volumes. Here's the syntax: ``` docker run --volumes-from <container_name_or_id> <image> ``` So put the job container name into the `env` context in this PR.

sillyguodong added 1 commit 2023-06-02 09:22:06 +00:00

Put the job container name into the env

checks / check and test (pull_request) Successful in 46s

Details

8f56fd068c

wxiaoguang reviewed 2023-06-02 10:27:59 +00:00

pkg/runner/run_context.go Outdated

						
				@ -255,6 +255,7 @@ func (rc *RunContext) startJobContainer() common.Executor {

						logger.Infof("\U0001f680  Start image=%s", image)

						name := rc.jobContainerName()

						rc.Env["JOB_CONTAINER_NAME"] = name

wxiaoguang commented

2023-06-02 10:27:59 +00:00

Is startHostEnvironment the right place for preparing rc.Env ?

Is `startHostEnvironment` the right place for preparing `rc.Env` ?

ChristopherHX commented

2023-06-02 10:52:14 +00:00

First-time contributor

No, startHostEnvironment doesn't create a docker job container at all and is used for creating a fake container structure to run all commands without docker on the host.

👍 1

sillyguodong marked this conversation as resolved

sillyguodong added 1 commit 2023-06-05 09:57:25 +00:00

add comment

checks / check and test (pull_request) Successful in 30s

Details

deabc6dee2

wolfogre approved these changes 2023-06-05 10:00:08 +00:00

wolfogre added 1 commit 2023-06-05 10:00:19 +00:00

Merge branch 'main' into add_env_of_job_container_name

checks / check and test (pull_request) Successful in 27s

Details