Patched options() to let container options propagate to job containers #80

Open
nicorac wants to merge 1 commits from nicorac/act:main into main
First-time contributor

This PR let "general" container config to be propagated to each job container.

See:

This PR let "general" container config to be propagated to each job container. See: - https://gitea.com/gitea/act_runner/issues/265#issuecomment-744382 - https://gitea.com/gitea/act_runner/issues/79 - https://gitea.com/gitea/act_runner/issues/378
nicorac added 1 commit 2023-10-17 06:53:35 +00:00
All checks were successful
checks / check and test (pull_request) Successful in 1m0s
33f5365c02
Patched options() to always return "general" container config
Owner

Is there any possible security problem of this patch?

Is there any possible security problem of this patch?
Author
First-time contributor

Is there any possible security problem of this patch?

Which kind of problem are you suspecting could be introduced?

In my mind config.yaml file and its container.options field is managed by the SysAdmin running the docker server (in my case that's me 😉), so a "trusted" entity.
It's like if Github SysAdmins will introduce new default env vars to action containers to set new network configs or (like in my case) set proxy config to be used to access the internet).

I'm not an expert and I'd like to know if I'm missing something...

> Is there any possible security problem of this patch? Which kind of problem are you suspecting could be introduced? In my mind `config.yaml` file and its `container.options` field is managed by the SysAdmin running the docker server (in my case that's me 😉), so a "trusted" entity. It's like if Github SysAdmins will introduce new default env vars to action containers to set new network configs or (like in my case) set proxy config to be used to access the internet). I'm not an expert and I'd like to know if I'm missing something...
nicorac force-pushed main from 33f5365c02 to d868bb469f 2023-11-16 13:12:18 +00:00 Compare
Author
First-time contributor

3 issues could be fixed by this PR: 79, 475 and 483.

So please, could anyone who's in charge of PR evaluation/merge... take care of it? 🙄

3 issues could be fixed by this PR: [79](https://gitea.com/gitea/act_runner/issues/79), [475](https://gitea.com/gitea/act_runner/issues/475) and [483](https://gitea.com/gitea/act_runner/issues/483). So please, could anyone who's in charge of PR evaluation/merge... take care of it? 🙄
lunny requested review from Zettat123 2024-02-19 07:09:43 +00:00
All checks were successful
checks / check and test (pull_request) Successful in 1m14s
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u main:nicorac-main
git checkout nicorac-main

Merge

Merge the changes and update on Gitea.
git checkout main
git merge --no-ff nicorac-main
git checkout main
git merge --ff-only nicorac-main
git checkout nicorac-main
git rebase main
git checkout main
git merge --no-ff nicorac-main
git checkout main
git merge --squash nicorac-main
git checkout main
git merge --ff-only nicorac-main
git checkout main
git merge nicorac-main
git push origin main
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/act#80
No description provided.