Patched options() to let container options propagate to job containers #80

nicorac · 2023-10-17T06:53:35Z

nicorac commented

2023-10-17 06:53:35 +00:00

This PR let "general" container config to be propagated to each job container.

See:

This PR let "general" container config to be propagated to each job container. See: - https://gitea.com/gitea/act_runner/issues/265#issuecomment-744382 - https://gitea.com/gitea/act_runner/issues/79 - https://gitea.com/gitea/act_runner/issues/378

👍 4

nicorac added 1 commit 2023-10-17 06:53:35 +00:00

Patched options() to always return "general" container config

checks / check and test (pull_request) Successful in 1m0s

Details

33f5365c02

nicorac referenced this pull request from gitea/act_runner

2023-10-17 06:55:55 +00:00

Provide a way to mount common volumes to Docker containers used by Actions #378

lunny commented

2023-10-19 05:17:53 +00:00

Is there any possible security problem of this patch?

nicorac commented

2023-10-19 08:05:48 +00:00

Is there any possible security problem of this patch?

Which kind of problem are you suspecting could be introduced?

In my mind config.yaml file and its container.options field is managed by the SysAdmin running the docker server (in my case that's me 😉), so a "trusted" entity.
It's like if Github SysAdmins will introduce new default env vars to action containers to set new network configs or (like in my case) set proxy config to be used to access the internet).

I'm not an expert and I'd like to know if I'm missing something...

> Is there any possible security problem of this patch? Which kind of problem are you suspecting could be introduced? In my mind `config.yaml` file and its `container.options` field is managed by the SysAdmin running the docker server (in my case that's me 😉), so a "trusted" entity. It's like if Github SysAdmins will introduce new default env vars to action containers to set new network configs or (like in my case) set proxy config to be used to access the internet). I'm not an expert and I'd like to know if I'm missing something...

nicorac force-pushed main from 33f5365c02 to d868bb469f

2023-11-16 13:12:18 +00:00

Compare

Shuenhoy referenced this pull request

2024-01-17 02:54:06 +00:00

Pass 'sleep' as container command rather than entrypoint #86

nicorac referenced this pull request from gitea/act_runner

2024-01-29 19:11:56 +00:00

Apply resource limitation on container during job #475

l.minopoli referenced this pull request from gitea/act_runner

2024-01-29 21:19:43 +00:00

Apply resource limitation on container during job #475

nicorac referenced this pull request from gitea/act_runner

2024-02-14 10:24:36 +00:00

config.yaml: container options are ignored with custom container #483

nicorac commented

2024-02-14 10:28:49 +00:00

3 issues could be fixed by this PR: 79, 475 and 483.

So please, could anyone who's in charge of PR evaluation/merge... take care of it? 🙄

3 issues could be fixed by this PR: [79](https://gitea.com/gitea/act_runner/issues/79), [475](https://gitea.com/gitea/act_runner/issues/475) and [483](https://gitea.com/gitea/act_runner/issues/483). So please, could anyone who's in charge of PR evaluation/merge... take care of it? 🙄

👍 1

lunny requested review from Zettat123 2024-02-19 07:09:43 +00:00

sillyguodong approved these changes 2024-02-23 06:19:08 +00:00

wolfogre approved these changes 2024-03-04 02:22:26 +00:00

wolfogre added 1 commit 2024-03-04 02:22:35 +00:00

Merge branch 'main' into main

checks / check and test (pull_request) Successful in 1m16s

Details

274344b62f

wolfogre merged commit 7e20ddf928 into main

2024-03-04 02:56:52 +00:00

wolfogre referenced this issue from a commit