fix: dont hardcode versions and tini #190

pj · 2023-05-16T17:21:29Z

pj commented

2023-05-16 17:21:29 +00:00

First-time contributor

Removes hardcoded package versions which will break as soon as any of these receives an update
Removes hardcoded tini which is included in docker since 2016 or even earlier

Removes hardcoded package versions which will break as soon as any of these receives an update Removes hardcoded `tini` which is included in docker since 2016 or even earlier

pj added 1 commit 2023-05-16 17:21:30 +00:00

fix: dont hardcode versions and tini

checks / check and test (pull_request) Failing after 39s

Details

f1e7a886c5

wolfogre commented

2023-05-17 06:24:55 +00:00

Thanks for your suggestion, I'm not very good at this, but here's some context I found, they may help. 😊

Removes hardcoded package versions which will break as soon as any of these receives an update

See DL3018, maybe RUN apk add --no-cache make=~4.3-r1 git=~2.38.5-r0?

Removes hardcoded tini which is included in docker since 2016 or even earlier

Related to #180.

See using-tini.

It still needs to pass the --init flag to docker run.

Thanks for your suggestion, I'm not very good at this, but here's some context I found, they may help. 😊 > Removes hardcoded package versions which will break as soon as any of these receives an update See [DL3018](https://github.com/hadolint/hadolint/wiki/DL3018), maybe `RUN apk add --no-cache make=~4.3-r1 git=~2.38.5-r0`? > Removes hardcoded `tini` which is included in docker since 2016 or even earlier Related to #180. See [using-tini](https://github.com/krallin/tini#using-tini). It still needs to pass the --init flag to docker run.

wolfogre added the

reviewed

needs feedback

label 2023-06-05 08:47:19 +00:00

wolfogre referenced this pull request

2023-06-06 03:25:05 +00:00

implement act_runner rootless image #208

pj commented

2023-06-06 18:40:37 +00:00

First-time contributor

Removes hardcoded tini which is included in docker since 2016 or even earlier

Related to #180.

See using-tini.

It still needs to pass the --init flag to docker run.

I'm aware of that but I don't know what you are implying? Hardcoding tini into container increases the size and tini version, which can easily be supplied by docker engine.

> > Removes hardcoded `tini` which is included in docker since 2016 or even earlier > > Related to #180. > > See [using-tini](https://github.com/krallin/tini#using-tini). > > It still needs to pass the --init flag to docker run. I'm aware of that but I don't know what you are implying? Hardcoding `tini` into container increases the size and `tini` version, which can easily be supplied by docker engine.

pj commented

2023-06-06 18:42:34 +00:00

First-time contributor

Thanks for your suggestion, I'm not very good at this, but here's some context I found, they may help. 😊

Removes hardcoded package versions which will break as soon as any of these receives an update

See DL3018, maybe RUN apk add --no-cache make=~4.3-r1 git=~2.38.5-r0?

That still breaks whenever update is pushed.

> Thanks for your suggestion, I'm not very good at this, but here's some context I found, they may help. 😊 > > > Removes hardcoded package versions which will break as soon as any of these receives an update > > See [DL3018](https://github.com/hadolint/hadolint/wiki/DL3018), maybe `RUN apk add --no-cache make=~4.3-r1 git=~2.38.5-r0`? That still breaks whenever update is pushed.

wolfogre removed the

reviewed

needs feedback

label 2023-06-08 04:09:46 +00:00

wolfogre referenced this pull request

2023-06-08 04:10:56 +00:00

Remove hadolint and improve Dockerfile #234

wolfogre referenced this issue from a commit

2023-06-09 02:50:34 +00:00

Remove hadolint and improve Dockerfile (#234)

wolfogre commented

2023-06-09 02:52:42 +00:00